You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2018/05/23 18:26:03 UTC
[GitHub] storm pull request #2689: STORM-3061: rocket, jms, and mqtt updates
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2689
STORM-3061: rocket, jms, and mqtt updates
This updates some dependencies for the jms examples, mqtt examples, rocketmq examples, and updates activemq implementation used for testing jms, rocketmq, and activemq.
I ran some manual tests of the example topologies that I could find. I couldn't make all of them really work, because there was no clear documentation about most of them on how to setup or run the example topologies.
mqtt examples using flink had no documentation at all so I wasn't able to successfully run anything. storm-jms-examples fails with what appears to be a JNI issue, but it fails exactly the same way on 1.2.3-SNAPSHOT too.
If someone with more experience with these could improve the documentation about how to run them that would be great.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3061-rmq
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2689
----
commit 95ea31da49825632c4fb6068cb50d8d315c59775
Author: Robert (Bobby) Evans <ev...@...>
Date: 2018-05-23T14:41:48Z
STORM-3061: Remove unneeded deps from rocketmq-examples
commit 433689c95526c3be92b3bec2fd3dbcfe6198fb64
Author: Robert (Bobby) Evans <ev...@...>
Date: 2018-05-23T17:53:44Z
STORM-3061: mqtt-update
----
---
[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2689
I just rebased, and if you want me to file separate JIRA for each of these I can, but 2.x is the time that we have to be able to do customer impacting upgrades like this.
I think I have done enough sanity tests that I feel comfortable with this change going in. If others want more testing I can pull this out to a separate JIRA.
---
[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2689
Hi @revans2 Now I'm on vacation. I will add a usage document for RocketMQ example after I get back next week.
---
[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2689
@revans2
Could we move this out of STORM-3061 (I meant filing a new issue)? This looks like not a thing to be reviewed sooner and we merged other PRs for STORM-3061 so may be better to break down and mark STORM-3061 as resolved.
---
[GitHub] storm pull request #2689: STORM-3061: rocket, jms, and mqtt updates
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2689
---
[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2689
@vesense @ptgoetz
Any updates on this?
---
[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2689
@vesense I am trying to get the RocketMQ example topology up and running so I can manually test that it is working, but there is no documentation on how to do it. I managed to download RocketMQ and set it up so there are no more exceptions in the logs, but I am no data is flowing. Do you happen to have a tool or instructions on how to publish and read the appropriate messages to/from the corresponding queues?
---
[GitHub] storm issue #2689: STORM-3061: rocket, jms, and mqtt updates
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2689
@ptgoetz I am trying to run all of the examples/tests I can to be sure that I didn't break anything when I upgraded versions. One of the issues I am running into is around the spring framework in the storm-jms-examples package. It looks like you wrote that code initially, or at least brought it in could you explain to me how to run it? I am having no luck making it work on any version of storm I have tried.
```
442 [main] INFO o.s.b.f.x.XmlBeanDefinitionReader - Loading XML bean definitions from class path resource [jms-activemq.xml]
Exception in thread "main" org.springframework.beans.factory.parsing.BeanDefinitionParsingException: Configuration problem: Unable to locate Spring NamespaceHandler for XML schema namespace [http://activemq.apache.org/schema/core]
Offending resource: class path resource [jms-activemq.xml]
```
---