You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by malayhm <gi...@git.apache.org> on 2017/09/05 21:17:25 UTC
[GitHub] zeppelin pull request #2569: ZEPPELIN-2562 Make Add paragraph button more pr...
GitHub user malayhm opened a pull request:
https://github.com/apache/zeppelin/pull/2569
ZEPPELIN-2562 Make Add paragraph button more prominent
### What is this PR for?
- Earlier add paragraph button was tiny plus between two paragraphs.
- With this change, we have added `Add Paragraph` text along with `+` and increased the height without any flicker so that user will get to know about adding a paragraph easily
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2562
### How should this be tested?
1. Build: mvn clean package -Denforcer.skip -DskipTests -Drat.skip
2. Mouse hover over the empty space between the paragraph to create a paragraph
### Screenshots (if appropriate)
Before:
After:
### Questions:
* Does the licenses files need update? - No
* Is there breaking changes for older versions? - No
* Does this needs documentation? - No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/malayhm/zeppelin ZEPPELIN-2562
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2569
----
commit 7704b1b58a6d160063b57dfcad0b2f84c2b32bc8
Author: Malay Majithia <ma...@gmail.com>
Date: 2017-09-05T21:11:48Z
ZEPPELIN-2562 Make Add paragraph button more prominent
----
---
[GitHub] zeppelin issue #2569: ZEPPELIN-2562 Make Add paragraph button more prominent
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Cool!
---
[GitHub] zeppelin issue #2569: ZEPPELIN-2562 Make Add paragraph button more prominent
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Personally, I like this change.
But just to make sure It would be nice to wait few days since this affects on user experiences.
---
[GitHub] zeppelin issue #2569: ZEPPELIN-2562 Make Add paragraph button more prominent
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Merge if no more discussion.
---
[GitHub] zeppelin pull request #2569: ZEPPELIN-2562 Make Add paragraph button more pr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2569
---
[GitHub] zeppelin issue #2569: ZEPPELIN-2562 Make Add paragraph button more prominent
Posted by malayhm <gi...@git.apache.org>.
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2569
@1ambda Sure.
---
[GitHub] zeppelin issue #2569: ZEPPELIN-2562 Make Add paragraph button more prominent
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Looks good to me
---
[GitHub] zeppelin issue #2569: ZEPPELIN-2562 Make Add paragraph button more prominent
Posted by malayhm <gi...@git.apache.org>.
Github user malayhm commented on the issue:
https://github.com/apache/zeppelin/pull/2569
@1ambda Can we merge this to master if there are no more discussions?
---
[GitHub] zeppelin issue #2569: ZEPPELIN-2562 Make Add paragraph button more prominent
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Tested and it works well!
@malayhm Could you try restart a failed CI task? https://travis-ci.org/malayhm/zeppelin/jobs/272238226
---