You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/07/03 23:26:31 UTC
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10861
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
---
M docs/topics/impala_shell_commands.xml
M docs/topics/impala_shell_running_commands.xml
2 files changed, 125 insertions(+), 299 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/10861/1
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10861 )
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10861/1/docs/topics/impala_shell_running_commands.xml
File docs/topics/impala_shell_running_commands.xml:
http://gerrit.cloudera.org:8080/#/c/10861/1/docs/topics/impala_shell_running_commands.xml@72
PS1, Line 72: Use <codeph>--</codeph> or <codeph>/* */</codeph> to denote a comment.
Use -- to denote a single comment or /* */ to denote a multiline comment.
http://gerrit.cloudera.org:8080/#/c/10861/1/docs/topics/impala_shell_running_commands.xml@84
PS1, Line 84: $
It should be ${variable_name}
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Jul 2018 06:53:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Adam Holley,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10861
to look at the new patch set (#2).
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
---
M docs/topics/impala_shell_commands.xml
M docs/topics/impala_shell_running_commands.xml
2 files changed, 128 insertions(+), 299 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/10861/2
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10861 )
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jul 2018 16:08:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10861 )
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/340/
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jul 2018 16:33:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10861 )
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jul 2018 16:08:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10861 )
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Reviewed-on: http://gerrit.cloudera.org:8080/10861
Reviewed-by: Adam Holley <ah...@cloudera.com>
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_shell_commands.xml
M docs/topics/impala_shell_running_commands.xml
2 files changed, 128 insertions(+), 299 deletions(-)
Approvals:
Adam Holley: Looks good to me, but someone else must approve
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10861 )
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jul 2018 15:59:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10861 )
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jul 2018 16:39:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10861 )
Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10861/1/docs/topics/impala_shell_running_commands.xml
File docs/topics/impala_shell_running_commands.xml:
http://gerrit.cloudera.org:8080/#/c/10861/1/docs/topics/impala_shell_running_commands.xml@72
PS1, Line 72: Use <codeph>--</codeph> or <codeph>/* */</codeph> to denote a comment.
> Use -- to denote a single comment or /* */ to denote a multiline comment.
Done
http://gerrit.cloudera.org:8080/#/c/10861/1/docs/topics/impala_shell_running_commands.xml@84
PS1, Line 84: $
> It should be ${variable_name}
Done
--
To view, visit http://gerrit.cloudera.org:8080/10861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb95785a143939a94d55d3565364afe1e26c1f3d
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jul 2018 15:44:29 +0000
Gerrit-HasComments: Yes