[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6843: Allow BYTES/Struct and complex type fields to exceed default max length

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #6843:
URL: https://github.com/apache/incubator-pinot/pull/6843#discussion_r620716882



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java
##########
@@ -381,10 +381,10 @@ public int size() {
 
     /**
      * Check if the data type is for fixed width data (INT, LONG, FLOAT, DOUBLE)
-     * or variable width data (STRING, BYTES)
+     * or variable width data (STRING, BYTES, STRUCT, MAP, LIST)
      */
     public boolean isFixedWidth() {
-      return this != STRING && this != BYTES;
+      return this == INT || this == LONG || this == FLOAT || this == DOUBLE;

Review comment:
       You may just want to do  `return isNumeric()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org