You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/07/14 13:10:24 UTC
[PR] feat(server-ng): serve HTTPS on the REST listener [iggy]
hubcio opened a new pull request, #3672:
URL: https://github.com/apache/iggy/pull/3672
http.tls.enabled was read but never acted on: the REST listener
always bound plaintext, so bearer tokens and passwords crossed
the wire in clear despite TLS being configured.
Terminate TLS with the compio-native rustls substrate the binary
transports already use, rather than pulling tokio via axum-server.
Handshakes run off the accept path behind a bounded channel so a
slow peer cannot stall accept. Connections are served through a
hand-rolled hyper-util auto loop over HyperStream::new_tls;
cyper_axum::serve only wraps plaintext streams, and splitting the
TLS stream deadlocks full-duplex HTTP on compio's BiLock. ALPN
advertises h2 and http/1.1 for parity with the legacy server.
Credential errors surface as ListenerCredentials instead of a
panic, and enabling TLS with an empty cert_file or key_file now
fails config validation at boot.
An integration test spawns iggy-server-ng with http.tls enabled
and asserts /ping and /users/login return 200 over HTTP/2,
proving certificate loading, the handshake pump, and ALPN end to
end. reqwest's http2 feature is now pinned instead of enabled
transitively via testcontainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server-ng): serve HTTPS on the REST listener [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski merged PR #3672:
URL: https://github.com/apache/iggy/pull/3672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server-ng): serve HTTPS on the REST listener [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3672:
URL: https://github.com/apache/iggy/pull/3672#issuecomment-4969551952
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3672?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.03%. Comparing base ([`c42eca7`](https://app.codecov.io/gh/apache/iggy/commit/c42eca779aea58bc6b1c64df6d4509c2aaade622?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4f84bcc`](https://app.codecov.io/gh/apache/iggy/commit/4f84bccaabbcb263e92cf9550677151d2c7c920a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3672 +/- ##
============================================
- Coverage 73.60% 72.03% -1.58%
Complexity 937 937
============================================
Files 1297 1234 -63
Lines 143769 139073 -4696
Branches 119329 119231 -98
============================================
- Hits 105822 100182 -5640
- Misses 34582 35612 +1030
+ Partials 3365 3279 -86
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3672/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3672/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.84% <ø> (+<0.01%)` | :arrow_up: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3672/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.44% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3672/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.19% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3672/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.17% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3672/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.29% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3672/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.27% <ø> (-4.08%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3672/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.94% <ø> (-25.35%)` | :arrow_down: |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3672?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/configs/src/server\_ng\_config/validators.rs](https://app.codecov.io/gh/apache/iggy/pull/3672?src=pr&el=tree&filepath=core%2Fconfigs%2Fsrc%2Fserver_ng_config%2Fvalidators.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25maWdzL3NyYy9zZXJ2ZXJfbmdfY29uZmlnL3ZhbGlkYXRvcnMucnM=) | `42.42% <ø> (ø)` | |
| [core/server-ng/src/http.rs](https://app.codecov.io/gh/apache/iggy/pull/3672?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fhttp.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL2h0dHAucnM=) | `57.05% <ø> (+1.77%)` | :arrow_up: |
... and [123 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3672/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org