You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/03 11:43:05 UTC
[GitHub] [arrow] xhochy opened a new pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
xhochy opened a new pull request #7342:
URL: https://github.com/apache/arrow/pull/7342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#issuecomment-644821869
We should try to ship mimalloc in Windows conda builds for 1.0.0, @kszucs do you think you might be able to help?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#issuecomment-644835003
I'm a bit confused since mimalloc is already enabled in the [arrow-cpp-feedstock](https://github.com/conda-forge/arrow-cpp-feedstock/blob/master/recipe/bld-arrow.bat#L23) although its license is not included in ours.
I assume we should leave the conda forge packages as is and have a jira about including mimalloc's license in our license file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#issuecomment-638151497
https://issues.apache.org/jira/browse/ARROW-9023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#discussion_r435383262
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1367,7 +1370,7 @@ endif()
# ----------------------------------------------------------------------
# mimalloc - Cross-platform high-performance allocator, from Microsoft
-if(ARROW_MIMALLOC)
+macro(build_mimalloc)
message(STATUS "Building (vendored) mimalloc from source")
# We only use a vendored mimalloc as we want to control its build options.
Review comment:
Is this comment obsolete? Does conda-forge uses the same build options as we do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on a change in pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
xhochy commented on a change in pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#discussion_r435385432
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1367,7 +1370,7 @@ endif()
# ----------------------------------------------------------------------
# mimalloc - Cross-platform high-performance allocator, from Microsoft
-if(ARROW_MIMALLOC)
+macro(build_mimalloc)
message(STATUS "Building (vendored) mimalloc from source")
# We only use a vendored mimalloc as we want to control its build options.
Review comment:
😞 Thought so but missed `MI_OVERRIDE`, not sure whether we can set that on conda-forge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#issuecomment-644823682
> We should try to ship mimalloc in Windows conda builds for 1.0.0, @kszucs do you think you might be able to help?
Vendoring should be a viable solution if we include the LICENSE file. The conda package is not working on Windows and I fail debug it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#issuecomment-644825286
Ah OK. Then using BUNDLED on conda-forge should be OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy closed pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
xhochy closed pull request #7342:
URL: https://github.com/apache/arrow/pull/7342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7342: ARROW-9023: [C++] Use mimalloc conda package
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7342:
URL: https://github.com/apache/arrow/pull/7342#issuecomment-644680940
Will have a look at this in some weeks again, closing for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org