You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/11/09 01:47:43 UTC
[GitHub] [samza] shisheng-1 opened a new pull request #1555: Improve GRADLE build Performance
shisheng-1 opened a new pull request #1555:
URL: https://github.com/apache/samza/pull/1555
[Compiler daemon](https://docs.gradle.org/current/userguide/performance.html#compiler_daemon). The Gradle Java plugin allows you to run the compiler as a separate process by setting `options.fork = true`. This feature can lead to much less garbage collection and make Gradle’s infrastructure faster. This project has more than 1000 source files. We can consider enabling this feature.
=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] cameronlee314 commented on a change in pull request #1555: Improve GRADLE build Performance
Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on a change in pull request #1555:
URL: https://github.com/apache/samza/pull/1555#discussion_r746877284
##########
File path: build.gradle
##########
@@ -102,6 +102,10 @@ rat {
}
allprojects {
+ tasks.withType(JavaCompile).configureEach {
+ options.fork = true
+ }
+
Review comment:
Minor: Could you please use 2 spaces for indentation instead of 4? Just for consistency with the rest of the file.
##########
File path: build.gradle
##########
@@ -102,6 +102,10 @@ rat {
}
allprojects {
+ tasks.withType(JavaCompile).configureEach {
Review comment:
Minor: Does `tasks.withType(JavaCompile).configureEach` do something different than `tasks.withType(JavaCompile)`? https://docs.gradle.org/5.2.1/dsl/org.gradle.api.tasks.compile.JavaCompile.html doesn't have the `configureEach`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] shisheng-1 commented on a change in pull request #1555: Improve GRADLE build Performance
Posted by GitBox <gi...@apache.org>.
shisheng-1 commented on a change in pull request #1555:
URL: https://github.com/apache/samza/pull/1555#discussion_r747945123
##########
File path: build.gradle
##########
@@ -102,6 +102,10 @@ rat {
}
allprojects {
+ tasks.withType(JavaCompile).configureEach {
+ options.fork = true
+ }
+
Review comment:
Ok, two spaces now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] shisheng-1 commented on a change in pull request #1555: Improve GRADLE build Performance
Posted by GitBox <gi...@apache.org>.
shisheng-1 commented on a change in pull request #1555:
URL: https://github.com/apache/samza/pull/1555#discussion_r747947140
##########
File path: build.gradle
##########
@@ -102,6 +102,10 @@ rat {
}
allprojects {
+ tasks.withType(JavaCompile).configureEach {
Review comment:
That difference comes from different Gradle version.
As this project use Gradle 5.2.1, so we should use `tasks.withType(JavaCompile)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org