You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/03 16:37:13 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
ndimiduk opened a new pull request #1844:
URL: https://github.com/apache/hbase/pull/1844
* Add a section calling out our categorical lack of support for
non-LTS Java versions.
* Provide clarification as to the meaning of the 'red x' in our
support matrix.
* Transpose the support matrix to have HBase releases along the x-axis
and Java releases along the y-axis, because there are more Java
releases than HBase release categories.
* Update the JDK11 status in the matrix.
* Add a note qualifying our JDK11 support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-638317257
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 47s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 3m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | |
| uname | Linux dc5468b6070e 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0078268203 |
| Max. process+thread count | 46 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
+JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on
+link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264].
+====
-.Long Term Support JDKs are recommended
+.HotSpot vs. OpenJ9
[TIP]
====
-HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS)
-either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only
-applicable version and that the next likely version to see testing will be Java 11 near Q3 2018.
+At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the
+JVM. When selecting your JDK distribution, please take this into consideration.
====
.Java support by release line
-[cols="6*^.^", options="header"]
+[cols="4*^.^", options="header"]
|===
-|HBase Version
-|JDK 7
-|JDK 8
-|JDK 9 (Non-LTS)
-|JDK 10 (Non-LTS)
-|JDK 11
-
-|2.1+
+|Java Version
+|HBase 1.3+
+|HBase 2.1+
+|HBase 2.3+
+
+|JDK6
+|icon:times-circle[role="red"]
|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK7
+|icon:check-circle[role="green"]
+|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK8
|icon:check-circle[role="green"]
Review comment:
Although this doesn't mean that users can't compile 1.3+ with JDK 1.8, but branch-1 is still not 1.8 compatible source code wise. I am not sure whether this means we should mark this `red` (we can run clusters on Java 8 env but code is not compatible)
Edit: Looks like we are not talking about source code compatibility but LTS versions only. So, maybe good to keep this `green`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-639052541
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 16s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 3m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | |
| uname | Linux 22d668433112 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 61a7468df7 |
| Max. process+thread count | 48 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-639667285
@busbey
> the intro paragraph explains the warning sign designation but it is not used at all
Oh you're right. Since I pulled out the non-LTS releases, that category is unused. I could drop it entirely, I suppose, or redefine it.
> jdk11 has a green check mark, which is explained as an expected deployment type, but then has a note that describes limitations to the readiness that sound a lot like the explanation of the warning sign / yellow designation. why not just list it as warning sign / yellow and keep the same note that explains why?
That would be fine. I think that since the defined meaning of yellow/warning is not used, we can use this indication for this purpose instead.
> do we still need to list jdk6 if it is a no everywhere? The intro paragraph could just say "if a version is not listed you should assume it is (x)". e.g. we don't list jdk 1.5 or 1.4 but I don't think anyone is expecting us to.
Existing content mentioned JDK6, so I preserved it's mention. I can drop explicit mention of JDK6 and add the language you describe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-638316749
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 2m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | |
| uname | Linux 438b3b478c81 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0078268203 |
| Max. process+thread count | 41 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r435622827
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
+JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on
+link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264].
+====
-.Long Term Support JDKs are recommended
+.HotSpot vs. OpenJ9
[TIP]
====
-HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS)
-either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only
-applicable version and that the next likely version to see testing will be Java 11 near Q3 2018.
+At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the
+JVM. When selecting your JDK distribution, please take this into consideration.
====
.Java support by release line
-[cols="6*^.^", options="header"]
+[cols="4*^.^", options="header"]
|===
-|HBase Version
-|JDK 7
-|JDK 8
-|JDK 9 (Non-LTS)
-|JDK 10 (Non-LTS)
-|JDK 11
-
-|2.1+
+|Java Version
+|HBase 1.3+
+|HBase 2.1+
+|HBase 2.3+
+
+|JDK6
+|icon:times-circle[role="red"]
|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK7
+|icon:check-circle[role="green"]
+|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK8
|icon:check-circle[role="green"]
Review comment:
yeah this chart has always been about runtime version supports. good clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r434919844
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
+JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on
+link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264].
+====
-.Long Term Support JDKs are recommended
+.HotSpot vs. OpenJ9
[TIP]
====
-HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS)
-either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only
-applicable version and that the next likely version to see testing will be Java 11 near Q3 2018.
+At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the
+JVM. When selecting your JDK distribution, please take this into consideration.
====
.Java support by release line
-[cols="6*^.^", options="header"]
+[cols="4*^.^", options="header"]
|===
-|HBase Version
-|JDK 7
-|JDK 8
-|JDK 9 (Non-LTS)
-|JDK 10 (Non-LTS)
-|JDK 11
-
-|2.1+
+|Java Version
+|HBase 1.3+
+|HBase 2.1+
+|HBase 2.3+
+
+|JDK6
+|icon:times-circle[role="red"]
|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK7
+|icon:check-circle[role="green"]
+|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK8
|icon:check-circle[role="green"]
Review comment:
We're talking about runtime support here. You're right though, the language is not clear. Let me take another swing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #1844:
URL: https://github.com/apache/hbase/pull/1844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
+JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on
+link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264].
+====
-.Long Term Support JDKs are recommended
+.HotSpot vs. OpenJ9
[TIP]
====
-HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS)
-either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only
-applicable version and that the next likely version to see testing will be Java 11 near Q3 2018.
+At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the
+JVM. When selecting your JDK distribution, please take this into consideration.
====
.Java support by release line
-[cols="6*^.^", options="header"]
+[cols="4*^.^", options="header"]
|===
-|HBase Version
-|JDK 7
-|JDK 8
-|JDK 9 (Non-LTS)
-|JDK 10 (Non-LTS)
-|JDK 11
-
-|2.1+
+|Java Version
+|HBase 1.3+
+|HBase 2.1+
+|HBase 2.3+
+
+|JDK6
+|icon:times-circle[role="red"]
|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK7
+|icon:check-circle[role="green"]
+|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK8
|icon:check-circle[role="green"]
Review comment:
Although this doesn't mean that users can't compile 1.3+ with JDK 1.8, but branch-1 is still not 1.8 compatible source code wise. I am not sure whether this means we should mark this `red` because ppl can run clusters on Java 8 env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] joshelser commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r435309158
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
Review comment:
Maybe, make the previous paragraph..
> blah blah blah long-winded, or "untested"
And then just use that "untested" here? Maybe we can define exactly what we mean once and just use that again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r434920380
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
Review comment:
Yeah you're right. "support" is not a great term, the the world of enterprise software. "You're unlikely to find receptive community engagement" is a bit long-winded, but honest. The earlier phrasing wasn't mine, but I'll try again with it as a model.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
+JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on
+link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264].
+====
-.Long Term Support JDKs are recommended
+.HotSpot vs. OpenJ9
[TIP]
====
-HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS)
-either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only
-applicable version and that the next likely version to see testing will be Java 11 near Q3 2018.
+At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the
+JVM. When selecting your JDK distribution, please take this into consideration.
====
.Java support by release line
-[cols="6*^.^", options="header"]
+[cols="4*^.^", options="header"]
|===
-|HBase Version
-|JDK 7
-|JDK 8
-|JDK 9 (Non-LTS)
-|JDK 10 (Non-LTS)
-|JDK 11
-
-|2.1+
+|Java Version
+|HBase 1.3+
+|HBase 2.1+
+|HBase 2.3+
+
+|JDK6
+|icon:times-circle[role="red"]
|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK7
+|icon:check-circle[role="green"]
+|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK8
|icon:check-circle[role="green"]
Review comment:
Although this doesn't mean that users can't compile 1.3+ with JDK 1.8, but branch-1 is still not 1.8 compatible source code wise. I am not sure whether this means we should mark this `red` (we can run clusters on Java 8 env but code is not compatible)
Edit: Looks like we are not talking about source code compatibility but LTS versions for deployment only. So yeah, good to keep this `green` because deployment is supported with JDK 1.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-639060302
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 42s | master passed |
| +0 :ok: | refguide | 4m 48s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 20s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 4m 53s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 19m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 22472843d9eb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 61a7468df7 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/artifact/yetus-general-check/output/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/artifact/yetus-general-check/output/patch-site/book.html |
| Max. process+thread count | 78 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r434793703
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
+JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on
+link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264].
+====
-.Long Term Support JDKs are recommended
+.HotSpot vs. OpenJ9
[TIP]
====
-HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS)
-either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only
-applicable version and that the next likely version to see testing will be Java 11 near Q3 2018.
+At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the
+JVM. When selecting your JDK distribution, please take this into consideration.
====
.Java support by release line
-[cols="6*^.^", options="header"]
+[cols="4*^.^", options="header"]
|===
-|HBase Version
-|JDK 7
-|JDK 8
-|JDK 9 (Non-LTS)
-|JDK 10 (Non-LTS)
-|JDK 11
-
-|2.1+
+|Java Version
+|HBase 1.3+
+|HBase 2.1+
+|HBase 2.3+
+
+|JDK6
+|icon:times-circle[role="red"]
|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK7
+|icon:check-circle[role="green"]
+|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK8
|icon:check-circle[role="green"]
Review comment:
JDK8 should be `red` for HBase 1.3+ right? branch-1.3 and 1.4 have `maven-compiler-plugin` source and target as 1.7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-638330509
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 43s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 49s | master passed |
| +0 :ok: | refguide | 7m 8s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 35s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 7m 5s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. |
| | | 26m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 3132261373a7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0078268203 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/artifact/yetus-general-check/output/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/artifact/yetus-general-check/output/patch-site/book.html |
| Max. process+thread count | 78 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-639042818
Rebased, and attempted to address all comments. Please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] joshelser commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r434713054
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
Review comment:
The word "supported" always turns my stomach (thanks, day-job) because people have such a wide breadth of what that means.
I liked your phrasing earlier around "If you encounter an issue with one of these JDK versions, our first ask will be to use a JDK version which has been tested". I'm not sure if there is a more concise way to encapsulate this.
(I'll also acknowledge that I'm overly sensitive to this terminology. If it's OK to others, then it's fine :) )
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
Review comment:
> or has been attempted and is known to not work.
I would just simplify this to be "or is known to not work".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-639708973
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 1m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | |
| uname | Linux 59d2858aacac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 89b7b5a7f9 |
| Max. process+thread count | 53 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-639051450
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 1m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | |
| uname | Linux 702b67b91227 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 61a7468df7 |
| Max. process+thread count | 41 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966
##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -97,55 +97,76 @@ This section lists required services and some required system configuration.
[[java]]
.Java
-The following table summarizes the recommendation of the HBase community wrt deploying on various
-Java versions. A icon:check-circle[role="green"] symbol is meant to indicate a base level of
+The following table summarizes the recommendations of the HBase community with respect to deploying
+on various Java versions. The icon:check-circle[role="green"] symbol indicates a base level of
testing and willingness to help diagnose and address issues you might run into. Similarly, an entry
-of icon:exclamation-circle[role="yellow"] or icon:times-circle[role="red"] generally means that
-should you run into an issue the community is likely to ask you to change the Java environment
-before proceeding to help. In some cases, specific guidance on limitations (e.g. whether compiling
-/ unit tests work, specific operational issues, etc) will also be noted.
+of icon:exclamation-circle[role="yellow"] means that, should you run into an issue, the community
+is likely to ask you to change the Java environment rather than proceeding to help on that Java
+version. This applies categorically to Non-LTS releases (see below). The
+icon:times-circle[role="red"] means that support has been dropped for this version or has been
+attempted and is known to not work. For combinations of newer JDK with older HBase releases, it's
+likely that there are known compatibility issues that cannot be addressed under our compatibility
+guarantees, making that combination impossible. In some cases, specific guidance on limitations
+(e.g. whether compiling / unit tests work, specific operational issues, etc) will also be noted.
+
+.Long-Term Support JDKs are Recommended
+[WARNING]
+====
+HBase recommends downstream users rely on JDK releases that are marked as Long-Term Supported
+(LTS), either from the OpenJDK project or vendors. At the time of this writing, the following JDK
+releases are NOT LTS releases and are NOT supported by the Apache HBase community: JDK9, JDK10,
+JDK12, JDK13, and JDK14. Community discussion around this decision is recorded on
+link:https://issues.apache.org/jira/browse/HBASE-20264[HBASE-20264].
+====
-.Long Term Support JDKs are recommended
+.HotSpot vs. OpenJ9
[TIP]
====
-HBase recommends downstream users rely on JDK releases that are marked as Long Term Supported (LTS)
-either from the OpenJDK project or vendors. As of March 2018 that means Java 8 is the only
-applicable version and that the next likely version to see testing will be Java 11 near Q3 2018.
+At this time, all testing performed by the Apache HBase project runs on the HotSpot variant of the
+JVM. When selecting your JDK distribution, please take this into consideration.
====
.Java support by release line
-[cols="6*^.^", options="header"]
+[cols="4*^.^", options="header"]
|===
-|HBase Version
-|JDK 7
-|JDK 8
-|JDK 9 (Non-LTS)
-|JDK 10 (Non-LTS)
-|JDK 11
-
-|2.1+
+|Java Version
+|HBase 1.3+
+|HBase 2.1+
+|HBase 2.3+
+
+|JDK6
+|icon:times-circle[role="red"]
|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK7
+|icon:check-circle[role="green"]
+|icon:times-circle[role="red"]
+|icon:times-circle[role="red"]
+
+|JDK8
|icon:check-circle[role="green"]
Review comment:
Although this doesn't mean that users can't compile 1.3+ with JDK 1.8, but branch-1 is still not 1.8 compatible source code wise. I am not sure whether this means we should mark this `red` (we can run clusters on Java 8 env but code is not compatible)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-639721510
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 9s | master passed |
| +0 :ok: | refguide | 5m 28s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 47s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 5m 33s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 22m 7s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux d253de291117 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 89b7b5a7f9 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/artifact/yetus-general-check/output/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/artifact/yetus-general-check/output/patch-site/book.html |
| Max. process+thread count | 65 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1844:
URL: https://github.com/apache/hbase/pull/1844#issuecomment-639705935
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 45s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 2m 54s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1844 |
| Optional Tests | |
| uname | Linux b24ad8dc732a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 89b7b5a7f9 |
| Max. process+thread count | 46 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org