You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "libenchao (via GitHub)" <gi...@apache.org> on 2024/01/18 14:49:46 UTC
[PR] Build: config locale = 'en_US' for javadoc task [calcite]
libenchao opened a new pull request, #3637:
URL: https://github.com/apache/calcite/pull/3637
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6212] Config locale = 'en_US' for javadoc task [calcite]
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on code in PR #3637:
URL: https://github.com/apache/calcite/pull/3637#discussion_r1458197251
##########
build.gradle.kts:
##########
@@ -486,6 +486,8 @@ allprojects {
(options as StandardJavadocDocletOptions).apply {
// Please refrain from using non-ASCII chars below since the options are passed as
// javadoc.options file which is parsed with "default encoding"
+ // locale should be placed at the head of any options: https://docs.gradle.org/current/javadoc/org/gradle/external/javadoc/CoreJavadocOptions.html#getLocale
+ locale = "en_US"
Review Comment:
Yes, I do think so. I'll do this for avatica once this is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: config locale = 'en_US' for javadoc task [calcite]
Posted by "JiajunBernoulli (via GitHub)" <gi...@apache.org>.
JiajunBernoulli commented on PR #3637:
URL: https://github.com/apache/calcite/pull/3637#issuecomment-1899500249
Is it better to register the affected version with Jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: config locale = 'en_US' for javadoc task [calcite]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #3637:
URL: https://github.com/apache/calcite/pull/3637#discussion_r1457562119
##########
build.gradle.kts:
##########
@@ -486,6 +486,8 @@ allprojects {
(options as StandardJavadocDocletOptions).apply {
// Please refrain from using non-ASCII chars below since the options are passed as
// javadoc.options file which is parsed with "default encoding"
+ // locale should be placed at the head of any options: https://docs.gradle.org/current/javadoc/org/gradle/external/javadoc/CoreJavadocOptions.html#getLocale
+ locale = "en_US"
Review Comment:
Nice finding
Am I correct that same thing should be done for Avatica?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6212] Config locale = 'en_US' for javadoc task [calcite]
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on PR #3637:
URL: https://github.com/apache/calcite/pull/3637#issuecomment-1899532571
> Is it better to register the affected version with Jira?
I've logged CALCITE-6212, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6212] Config locale = 'en_US' for javadoc task [calcite]
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on code in PR #3637:
URL: https://github.com/apache/calcite/pull/3637#discussion_r1458215905
##########
build.gradle.kts:
##########
@@ -486,6 +486,8 @@ allprojects {
(options as StandardJavadocDocletOptions).apply {
// Please refrain from using non-ASCII chars below since the options are passed as
// javadoc.options file which is parsed with "default encoding"
+ // locale should be placed at the head of any options: https://docs.gradle.org/current/javadoc/org/gradle/external/javadoc/CoreJavadocOptions.html#getLocale
+ locale = "en_US"
Review Comment:
The PR against avatica is now available for review: https://github.com/apache/calcite-avatica/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6212] Config locale = 'en_US' for javadoc task [calcite]
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao closed pull request #3637: [CALCITE-6212] Config locale = 'en_US' for javadoc task
URL: https://github.com/apache/calcite/pull/3637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org