You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangzhonnew <gi...@git.apache.org> on 2015/04/02 04:52:39 UTC
[GitHub] spark pull request: [SPARK-6639]Create a new script to start multi...
GitHub user wangzhonnew opened a pull request:
https://github.com/apache/spark/pull/5323
[SPARK-6639]Create a new script to start multiple masters
start-slaves.sh script is able to read from slaves file and start slaves node in multiple boxes.
However in standalone mode if I want to use multiple masters, I’ll have to start masters in each individual box, and also need to provide the list of masters’ hostname+port to each worker. ( start-slaves.sh only take 1 master ip+port for now)
So I added several files including sbin/start-masters.sh , sbin/stop-masters.sh , conf/masters, and also modified few files so that start-all.sh/ stop-all.sh is going to start/stop all masters and slaves.
start-slaves.sh is also going to read masters file in order to fill master node list in spark connection string.
If conf/masters file does not exist, start-all.sh is going to start a master node on localhost.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SequoiaDB/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5323
----
commit bfe362c74efdddb6cd7b9c9a8083bd2971a3ad1a
Author: Tao Wang <ta...@sequoiadb.com>
Date: 2015-03-06T07:55:17Z
Merge pull request #1 from apache/master
Update from original
commit 2c250f61048a0692b3f67522de47c5617657aa03
Author: Tao Wang <ta...@sequoiadb.com>
Date: 2015-04-01T06:30:57Z
Merge remote-tracking branch 'upstream/master'
commit 653a04da390cdbd85c7449f5aae674cdbbd8c2b7
Author: Tao Wang <ta...@sequoiadb.com>
Date: 2015-04-01T08:04:25Z
add start-masters
commit bb458afe552a92bbd51e93f6c77de0adb8727f94
Author: Tao Wang <ta...@sequoiadb.com>
Date: 2015-04-01T08:27:06Z
[SPARK-6639]Create a new script to start multiple masters
commit 7492d52751983b92fc294b604ba8b29cd4c744a4
Author: Tao Wang <ta...@sequoiadbcom>
Date: 2015-04-02T02:47:39Z
[SPARK-6639]Create a new script to start multiple masters
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6639]Create a new script to start multi...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5323#issuecomment-148825846
Hey @wangzhonnew, it looks like this PR has become stale. I don't think that this has been a widely-requested feature and I'm not sure that we have the review bandwidth to look at a bunch of bash code for such an uncommonly-used feature. Therefore, would you mind closing this PR for now in order to de-clutter the review queue? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6639]Create a new script to start multi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5323#issuecomment-88708786
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6639]Create a new script to start multi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5323
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org