[GitHub] [gobblin] ZihanLi58 commented on a diff in pull request #3681: [GOBBLIN-1819] Log helix workflow information and timeout information during submission wait / polling

["ZihanLi58 (via GitHub)" <gi...@apache.org>]

ZihanLi58 commented on code in PR #3681:
URL: https://github.com/apache/gobblin/pull/3681#discussion_r1171890905


##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java:
##########
@@ -1109,5 +1109,11 @@ public ContainerInfo(Container container, String helixParticipantId, String heli
       this.helixTag = helixTag;
       this.startupCommand = YarnService.this.buildContainerCommand(container, helixParticipantId, helixTag);
     }
+
+    @Override
+    public String toString() {
+      return "ContainerInfo{" + "container=" + container.getId() + ", helixParticipantId='" + helixParticipantId + '\''

Review Comment:
   Can we use string.format() to construct this string?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org