You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Otávio Gonçalves de Santana <os...@tomitribe.com> on 2019/01/09 10:16:32 UTC
Re: Optmizes try catch #323
Thank you for the review guys.
Could someone move it forward it, please?
On Fri, Dec 28, 2018 at 3:47 PM Otávio Gonçalves de Santana <
osantana@tomitribe.com> wrote:
>
> -
>
> Optimizes the try using the try-with-resources that allows us to
> declare resources to be used in a try block with the assurance that the
> resources will be closed when after execution of that block. An ARM
> automatic resource management by the JVM.
> -
>
> The use of multi-catch that removes redundancies catch treatment.
>
> https://github.com/apache/tomee/pull/323
>
Re: Optmizes try catch #323
Posted by Otávio Gonçalves de Santana <os...@tomitribe.com>.
Thank you
On Wed, Jan 9, 2019, 14:16 Bruno Baptista <brunobat@gmail.com wrote:
> The PR looks good to me.
>
> Thanks Otávio and Happy Birthday to you!
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 09/01/19 10:59, Jean-Louis Monteiro wrote:
> > I reviewed it and though I merged it, but probably dreamt it. Sorry
> > about that
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Wed, Jan 9, 2019 at 11:54 AM Bruno Baptista <br...@gmail.com>
> wrote:
> >
> >> Hi Otávio,
> >>
> >> I will take a look.
> >>
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 09/01/19 10:16, Otávio Gonçalves de Santana wrote:
> >>> Thank you for the review guys.
> >>> Could someone move it forward it, please?
> >>>
> >>> On Fri, Dec 28, 2018 at 3:47 PM Otávio Gonçalves de Santana <
> >>> osantana@tomitribe.com> wrote:
> >>>
> >>>> -
> >>>>
> >>>> Optimizes the try using the try-with-resources that allows us to
> >>>> declare resources to be used in a try block with the assurance
> that
> >> the
> >>>> resources will be closed when after execution of that block. An
> ARM
> >>>> automatic resource management by the JVM.
> >>>> -
> >>>>
> >>>> The use of multi-catch that removes redundancies catch treatment.
> >>>>
> >>>> https://github.com/apache/tomee/pull/323
> >>>>
>
Re: Optmizes try catch #323
Posted by Bruno Baptista <br...@gmail.com>.
The PR looks good to me.
Thanks Otávio and Happy Birthday to you!
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 09/01/19 10:59, Jean-Louis Monteiro wrote:
> I reviewed it and though I merged it, but probably dreamt it. Sorry
> about that
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Wed, Jan 9, 2019 at 11:54 AM Bruno Baptista <br...@gmail.com> wrote:
>
>> Hi Otávio,
>>
>> I will take a look.
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 09/01/19 10:16, Otávio Gonçalves de Santana wrote:
>>> Thank you for the review guys.
>>> Could someone move it forward it, please?
>>>
>>> On Fri, Dec 28, 2018 at 3:47 PM Otávio Gonçalves de Santana <
>>> osantana@tomitribe.com> wrote:
>>>
>>>> -
>>>>
>>>> Optimizes the try using the try-with-resources that allows us to
>>>> declare resources to be used in a try block with the assurance that
>> the
>>>> resources will be closed when after execution of that block. An ARM
>>>> automatic resource management by the JVM.
>>>> -
>>>>
>>>> The use of multi-catch that removes redundancies catch treatment.
>>>>
>>>> https://github.com/apache/tomee/pull/323
>>>>
Re: Optmizes try catch #323
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
I reviewed it and though I merged it, but probably dreamt it. Sorry
about that
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Jan 9, 2019 at 11:54 AM Bruno Baptista <br...@gmail.com> wrote:
> Hi Otávio,
>
> I will take a look.
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 09/01/19 10:16, Otávio Gonçalves de Santana wrote:
> > Thank you for the review guys.
> > Could someone move it forward it, please?
> >
> > On Fri, Dec 28, 2018 at 3:47 PM Otávio Gonçalves de Santana <
> > osantana@tomitribe.com> wrote:
> >
> >> -
> >>
> >> Optimizes the try using the try-with-resources that allows us to
> >> declare resources to be used in a try block with the assurance that
> the
> >> resources will be closed when after execution of that block. An ARM
> >> automatic resource management by the JVM.
> >> -
> >>
> >> The use of multi-catch that removes redundancies catch treatment.
> >>
> >> https://github.com/apache/tomee/pull/323
> >>
>
Re: Optmizes try catch #323
Posted by Bruno Baptista <br...@gmail.com>.
Hi Otávio,
I will take a look.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 09/01/19 10:16, Otávio Gonçalves de Santana wrote:
> Thank you for the review guys.
> Could someone move it forward it, please?
>
> On Fri, Dec 28, 2018 at 3:47 PM Otávio Gonçalves de Santana <
> osantana@tomitribe.com> wrote:
>
>> -
>>
>> Optimizes the try using the try-with-resources that allows us to
>> declare resources to be used in a try block with the assurance that the
>> resources will be closed when after execution of that block. An ARM
>> automatic resource management by the JVM.
>> -
>>
>> The use of multi-catch that removes redundancies catch treatment.
>>
>> https://github.com/apache/tomee/pull/323
>>