[GitHub] [cassandra] blerer commented on pull request #1878: CASSANDRA-17221: Math fcts

[GitBox <gi...@apache.org>]

blerer commented on PR #1878:
URL: https://github.com/apache/cassandra/pull/1878#issuecomment-1271573281

   What I had in mind was something like:
   ```
      @Test
       public void testAbs()
       {
           assertAbsEquals(1, Int32Type.instance, 1);
           assertAbsEquals(0, Int32Type.instance, 0);
           assertAbsEquals(3, Int32Type.instance, -3);
   
           assertAbsEquals((byte) 1, ByteType.instance, (byte) 1);
           assertAbsEquals((byte) 0, ByteType.instance, (byte) 0);
           assertAbsEquals((byte) 3, ByteType.instance, (byte) -3);
   
           assertAbsEquals((short) 1, ShortType.instance, (short) 1);
           assertAbsEquals((short) 0, ShortType.instance, (short) 0);
           assertAbsEquals((short) 3, ShortType.instance, (short) -3);
   
           assertAbsEquals(1F, FloatType.instance, 1F);
           assertAbsEquals(1.5F, FloatType.instance, 1.5F);
           assertAbsEquals(0F, FloatType.instance, 0F);
           assertAbsEquals(3F, FloatType.instance, -3F);
           assertAbsEquals(3.7F, FloatType.instance, -3.7F);
   
           for (AbstractType<Long> type : new AbstractType[]{LongType.instance, CounterColumnType.instance})
           {
               assertAbsEquals(1L, LongType.instance, 1L);
               assertAbsEquals(0L, LongType.instance, 0L);
               assertAbsEquals(3L, LongType.instance, -3L);
           }
   
           assertAbsEquals(1.0, DoubleType.instance, 1.0);
           assertAbsEquals(1.5, DoubleType.instance, 1.5);
           assertAbsEquals(0.0, DoubleType.instance, 0.0);
           assertAbsEquals(3.0, DoubleType.instance, -3.0);
           assertAbsEquals(3.7, DoubleType.instance, -3.7);
   
           assertAbsEquals(BigInteger.ONE, IntegerType.instance, BigInteger.ONE);
           assertAbsEquals(BigInteger.ZERO, IntegerType.instance, BigInteger.ZERO);
           assertAbsEquals(BigInteger.valueOf(3), IntegerType.instance, BigInteger.valueOf(-3));
   
           assertAbsEquals(BigDecimal.ONE, DecimalType.instance, BigDecimal.ONE);
           assertAbsEquals(BigDecimal.valueOf(1.5), DecimalType.instance, BigDecimal.valueOf(1.5));
           assertAbsEquals(BigDecimal.ZERO, DecimalType.instance, BigDecimal.ZERO);
           assertAbsEquals(BigDecimal.valueOf(3), DecimalType.instance, BigDecimal.valueOf(-3));
           assertAbsEquals(BigDecimal.valueOf(3.7), DecimalType.instance, BigDecimal.valueOf(-3.7));
       }
   
       private <T extends Number> void assertAbsEquals(T expected, NumberType<T> inputType, T inputValue)
       {
           assertFctEquals(MathFcts.absFct(inputType), expected, inputType, inputValue);
       }
   
       private <T extends Number> void assertFctEquals(ScalarFunction fct, T expected, NumberType<T> inputType, T inputValue)
       {
           ByteBuffer input = inputType.decompose(inputValue);
           assertEquals(expected, inputType.compose(executeFunction(fct, input)));
       }
   ```
   It makes the test a bit easier to read and we test each functions with the same input values


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org