You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2020/06/11 10:29:00 UTC
[jira] [Comment Edited] (MSHARED-922) Remove checksum creation from
other places than maven-resolver
[ https://issues.apache.org/jira/browse/MSHARED-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133135#comment-17133135 ]
Konrad Windszus edited comment on MSHARED-922 at 6/11/20, 10:28 AM:
--------------------------------------------------------------------
[~rfscholte] or [~khmarbaise] Would you have a look at https://github.com/apache/maven-artifact-transfer/pull/16? I didn't touch any ITs and they are still green, so I assume this is working as expected in both Eclipse Aether and Maven Resolver.
was (Author: kwin):
[~rfscholte] Would you have a lookk at https://github.com/apache/maven-artifact-transfer/pull/16? I didn't touch any ITs and they are still green, so I assume this is working as expected in both Eclipse Aether and Maven Resolver.
> Remove checksum creation from other places than maven-resolver
> --------------------------------------------------------------
>
> Key: MSHARED-922
> URL: https://issues.apache.org/jira/browse/MSHARED-922
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-artifact-transfer
> Affects Versions: maven-artifact-transfer-0.12.0
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently there are checksums (MD5/SHA1) being created at https://github.com/apache/maven-artifact-transfer/blob/87842f9c712eb6496b32d4aff09307d0970d9f7b/src/main/java/org/apache/maven/shared/transfer/project/deploy/internal/DefaultProjectDeployer.java#L130 which is used e.g. from the maven-deploy-plugin.
> IMHO only the Maven-Resolver should ever create checksums as this is also the only code leveraging the checksums. There is already code for that at https://github.com/apache/maven-resolver/blob/47edcfe69c4e52ced4cb93d65b7348b5645cdd68/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java#L557.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)