[eclipse plugin] Patch - gruupId fix

[Michal Maczka <Mm...@cqs.ch>]

This patch fixes the problem of generation of classpath entry for eclipse
project when groupId is used.

It seems that there is more bugs of this type plaguing other plugins as
well.
The same type of patch is needed for example by ear plugin.
I can apply the patch soon...

Michal

Index: plugin.jelly
===================================================================
RCS file:
/home/cvspublic/jakarta-turbine-maven/src/plugins-build/eclipse/plugin.jelly
,v
retrieving revision 1.15
diff -u -r1.15 plugin.jelly
--- plugin.jelly	4 Jan 2003 05:37:02 -0000	1.15
+++ plugin.jelly	10 Jan 2003 14:20:44 -0000
@@ -47,8 +47,8 @@
         </j:if>
 
         <classpathentry kind="var" path="JRE_LIB" rootpath="JRE_SRCROOT"
sourcepath="JRE_SRC"/>
-        <j:forEach var="lib" items="${pom.dependencies}">
-          <classpathentry kind="var"
path="MAVEN_REPO/${lib.getProjectId()}/jars/${lib.getArtifact()}"/>
+        <j:forEach var="lib" items="${pom.artifacts}">
+          <classpathentry kind="var" path="MAVEN_REPO${lib.getUrlPath()}"/>
         </j:forEach>
         <classpathentry kind="output" path="target\eclipse\classes"/>
       </classpath>

Re: [eclipse plugin] Patch - gruupId fix

[Jason van Zyl <ja...@zenplex.com>]

On Fri, 2003-01-10 at 09:25, Michal Maczka wrote:
> This patch fixes the problem of generation of classpath entry for eclipse
> project when groupId is used.
> 
> It seems that there is more bugs of this type plaguing other plugins as
> well.
> The same type of patch is needed for example by ear plugin.
> I can apply the patch soon...

You want to use ${lib.artifactDirectory} and not ${lib.groupId} as the
groupId may not be set. The logic has been changed such that if the
artifactDirectory will be the groupId if it is set otherwise it will be
project id. Checkout the deploy plugin for usage.

If you send me patches using ${lib.artifactDirectory} I'll apply them.

> Michal
> 
> Index: plugin.jelly
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-turbine-maven/src/plugins-build/eclipse/plugin.jelly
> ,v
> retrieving revision 1.15
> diff -u -r1.15 plugin.jelly
> --- plugin.jelly	4 Jan 2003 05:37:02 -0000	1.15
> +++ plugin.jelly	10 Jan 2003 14:20:44 -0000
> @@ -47,8 +47,8 @@
>          </j:if>
>  
>          <classpathentry kind="var" path="JRE_LIB" rootpath="JRE_SRCROOT"
> sourcepath="JRE_SRC"/>
> -        <j:forEach var="lib" items="${pom.dependencies}">
> -          <classpathentry kind="var"
> path="MAVEN_REPO/${lib.getProjectId()}/jars/${lib.getArtifact()}"/>
> +        <j:forEach var="lib" items="${pom.artifacts}">
> +          <classpathentry kind="var" path="MAVEN_REPO${lib.getUrlPath()}"/>
>          </j:forEach>
>          <classpathentry kind="output" path="target\eclipse\classes"/>
>        </classpath>
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
-- 
jvz.

Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
  
  -- Jacques Ellul, The Technological Society