You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/16 00:40:24 UTC
Re: Review Request 71069: Added end-to-end tests for agent draining.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71069/
-----------------------------------------------------------
(Updated July 16, 2019, 12:40 a.m.)
Review request for mesos, Benno Evers and Joseph Wu.
Summary (updated)
-----------------
Added end-to-end tests for agent draining.
Bugs: MESOS-9816
https://issues.apache.org/jira/browse/MESOS-9816
Repository: mesos
Description (updated)
-------
This adds a minimal test for the DRAIN_AGENT scheduler call,
including verification of master API results once an agent
has been drained. A second test verifies the case where an
agent is marked gone when draining is complete.
Diffs (updated)
-----
include/mesos/v1/mesos.hpp df67f64fc537819bf8607e6d6b4a478b544df69e
src/tests/api_tests.cpp af1d215f00c8c2224e807677afb4af2d3521235a
src/v1/mesos.cpp be479e34042fb4a76b770d4a0e9abe454ff0447b
Diff: https://reviews.apache.org/r/71069/diff/2/
Changes: https://reviews.apache.org/r/71069/diff/1-2/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*MasterAPITest.DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 71069: Added end-to-end tests for agent draining.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71069/#review216635
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70822, 70910, 70911, 70923, 70956, 70957, 70924, 70996, 71008, 71041, 71055, 71069]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 16, 2019, 12:40 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71069/
> -----------------------------------------------------------
>
> (Updated July 16, 2019, 12:40 a.m.)
>
>
> Review request for mesos, Benno Evers and Joseph Wu.
>
>
> Bugs: MESOS-9816
> https://issues.apache.org/jira/browse/MESOS-9816
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a minimal test for the DRAIN_AGENT scheduler call,
> including verification of master API results once an agent
> has been drained. A second test verifies the case where an
> agent is marked gone when draining is complete.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.hpp df67f64fc537819bf8607e6d6b4a478b544df69e
> src/tests/api_tests.cpp af1d215f00c8c2224e807677afb4af2d3521235a
> src/v1/mesos.cpp be479e34042fb4a76b770d4a0e9abe454ff0447b
>
>
> Diff: https://reviews.apache.org/r/71069/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*MasterAPITest.DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 71069: Added end-to-end tests for agent draining.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71069/#review216668
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 15, 2019, 5:40 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71069/
> -----------------------------------------------------------
>
> (Updated July 15, 2019, 5:40 p.m.)
>
>
> Review request for mesos, Benno Evers and Joseph Wu.
>
>
> Bugs: MESOS-9816
> https://issues.apache.org/jira/browse/MESOS-9816
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a minimal test for the DRAIN_AGENT scheduler call,
> including verification of master API results once an agent
> has been drained. A second test verifies the case where an
> agent is marked gone when draining is complete.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.hpp df67f64fc537819bf8607e6d6b4a478b544df69e
> src/tests/api_tests.cpp af1d215f00c8c2224e807677afb4af2d3521235a
> src/v1/mesos.cpp be479e34042fb4a76b770d4a0e9abe454ff0447b
>
>
> Diff: https://reviews.apache.org/r/71069/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*MasterAPITest.DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>