Re: [PR] fix: use per-expression eval mode for decimal promotion [datafusion-comet]

["peterxcli (via GitHub)" <gi...@apache.org>]

peterxcli commented on PR #5171:
URL: https://github.com/apache/datafusion-comet/pull/5171#issuecomment-5149335280

   @andygrove Thanks for the review!
   
   > 1. The new regression test does not run on Spark 4.2.
   
   - moved `CometDecimalArithmeticViewSuite` to `spark/src/test/spark-4.1+/`
   - added `src/test/${shims.minorPlusVerSrc}` into `pom.xml`
   
   > 2. The TRY assertion in the new test is currently vacuous.
   
   added scala test
   
   3. Only Add is covered, but the change touches five operators.
   
   added Subtract, Multiply, Divide and Remainder scala tests.
   
   4. Please document why the flag comes from the expression.
   
   added comment.
   
   5. The Divide wrapper is now provably redundant, and I would like a tracking issue for it.
   
   filed https://github.com/apache/datafusion-comet/issues/5190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org