[jira] [Commented] (SAMZA-647) A new KeyValueStore interface should support getAll(List)

["Chris Riccomini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494899#comment-14494899 ] 

Chris Riccomini commented on SAMZA-647:
---------------------------------------

Thanks! Posted review.

> A new KeyValueStore interface should support getAll(List<K>)
> ------------------------------------------------------------
>
>                 Key: SAMZA-647
>                 URL: https://issues.apache.org/jira/browse/SAMZA-647
>             Project: Samza
>          Issue Type: Improvement
>          Components: kv
>    Affects Versions: 0.9.0
>            Reporter: Mohamed Mahmoud (El-Geish)
>            Assignee: Mohamed Mahmoud (El-Geish)
>              Labels: features
>             Fix For: 0.10.0
>
>         Attachments: BatchingKeyValueStore.diff
>
>
> For stores that support multiGet, like RocksDB, this can improve performance when batch querying; this could be simply implemented as a pass-through call to the underlying storage engine.
> For stores that don't support multiGet, we can simply return an iterator for the corresponding values by looping over keys and calling get() for each one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)