You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Marco Risaliti (JIRA)" <ji...@apache.org> on 2007/12/22 16:54:42 UTC
[jira] Created: (OFBIZ-1544) New Styles For Catalog application
New Styles For Catalog application
----------------------------------
Key: OFBIZ-1544
URL: https://issues.apache.org/jira/browse/OFBIZ-1544
Project: OFBiz
Issue Type: Improvement
Components: product
Affects Versions: SVN trunk
Reporter: Marco Risaliti
Assignee: Marco Risaliti
Priority: Minor
Fix For: SVN trunk
Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554798 ]
Chris Howe commented on OFBIZ-1544:
-----------------------------------
Thanks Bilgin,
I didn't realize that it had been committed. When I had commented the svn related info wasn't there. That's odd given the timestamps.
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch, style.png
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: new_style_product2.patch
Removed deprecated CSS style.
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch, new_style_product2.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554666 ]
Bilgin Ibryam commented on OFBIZ-1544:
--------------------------------------
I like the new styles :)
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: (was: new_style_product.patch)
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554182 ]
Marco Risaliti commented on OFBIZ-1544:
---------------------------------------
Thank Adrian for the documentation link I did not remember of it, it can be very helpfull to me.
Jacopo, I agree with you but I'm not sure if apply those default value can impact on the screen widgets that are not more converted to the new layout, in any case I will let you know something more.
Did you think that the layout is correct or you have seen something strange to correct.
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: ModelForm_default_values.patch
Default values form widgets, may I have to create a new issue for this improvement ?
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ModelForm_default_values.patch, new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch, style.png
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1544:
---------------------------------
Attachment: style.png
Chris,
Here is the screenshot.
Just curious: why you not use demo server for this?
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch, style.png
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554136 ]
Marco Risaliti commented on OFBIZ-1544:
---------------------------------------
In rev. 606464, 606465 commit the first patch of this issue.
Please let me know if there are something wrong because I would like to continue to the others product application forms.
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti closed OFBIZ-1544.
---------------------------------
Resolution: Fixed
I have completed the restyling of Catalog application and so I will close it and start with facility application.
Please let me know if someone have some problems with the catalog application after the new restyling.
Is important also that now it's working correctly again on most of the browsers.
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_features.patch, ModelForm_default_values.patch, new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch, style.png
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554826 ]
Adrian Crum commented on OFBIZ-1544:
------------------------------------
Marco,
The ModelForm class already provides a default table style. If a style is being specified in a widget XML file, it is because the default style is being replaced with something else. The form widget default table style is a basic-table with dark grids. If you search all XML files for "default-table-style" you'll see it is used when something different is needed.
The other default styles you proposed look fine to me.
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_features.patch, ModelForm_default_values.patch, new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch, style.png
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: new_style_product.patch
The previous patch was wrong.
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: (was: new_style_catalogs_products.patch)
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch, new_style_product2.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: new_style_catalogs_products.patch
This is a new patch for new style css to the catalogs and products forms.
Feedback are welcome before commit this big patch, deprecated class has still to be removed from catalogs and products forms.
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_catalogs_products.patch, new_style_product.patch, new_style_product2.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554202 ]
Marco Risaliti commented on OFBIZ-1544:
---------------------------------------
Hi Adrian I have committed into rev. 606632 a patch for removing deprecated CSS style.
Could you please take a look if everything is ok and so I will take in mind this as template for the others forms ?
In detail I have some problem into the product tab of category (EditCategoryProducts.ftl)
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch, new_style_product2.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554175 ]
Jacopo Cappellato commented on OFBIZ-1544:
------------------------------------------
In my opinion, it this is going to be the standard layout, it would be ideal to have implicit styles for forms rows.
I mean that, if possible, we should try to arrange things so that it is not necessary to specify the following attribute in each and every form definition:
header-row-style="header-row"
default-table-style="basic-table"
odd-row-style="alternate-row"
We have recently removed (thanks to Adrian's css refactoring) a bunch of style attributes from forms definitions, and now we should do what we can to keep this approach (for the standard layout of forms).
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: new_style_product.patch
This is the last patch that in part solve the issue on product tab but it is not equal to the others style.
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: new_style_features.patch
Convertion of features screens to the new styles and removed reprecated style.
I will commit and continue with the promotions tab.
As usual feedback are welcome.
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_features.patch, ModelForm_default_values.patch, new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch, style.png
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554156 ]
Adrian Crum commented on OFBIZ-1544:
------------------------------------
Marco,
It would help if you could follow the UI refactoring guidelines while doing this work:
http://docs.ofbiz.org/display/OFBIZ/Back+Office+Applications+UI+Refactor
Thank you very much for your help on this!
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_product.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554828 ]
Adrian Crum commented on OFBIZ-1544:
------------------------------------
Marco,
Thinking about it more, I don't think we should supply a default style for the alternate row. Alternate row styles are typically used for long lists, but they are not used for every form.
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_features.patch, ModelForm_default_values.patch, new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch, style.png
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554667 ]
Chris Howe commented on OFBIZ-1544:
-----------------------------------
Could you attach a screenshot?
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Risaliti updated OFBIZ-1544:
----------------------------------
Attachment: new_style_catalogs_products2.patch.zip
This patch replace the previous one and now also the deprecated style has been removed.
I would like to know some feedback before commit this big patch.
I attached in a zip format because with a patch file I was not able to upload it.
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1544) New Styles For Catalog application
Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554817 ]
Marco Risaliti commented on OFBIZ-1544:
---------------------------------------
Hi Jacopo,
about the following request:
In my opinion, it this is going to be the standard layout, it would be ideal to have implicit styles for forms rows.
I mean that, if possible, we should try to arrange things so that it is not necessary to specify the following attribute in each and every form definition:
header-row-style="header-row"
default-table-style="basic-table"
odd-row-style="alternate-row"
We have recently removed (thanks to Adrian's css refactoring) a bunch of style attributes from forms definitions, and now we should do what we can to keep this approach (for the standard layout of forms).
I have tried to change the ModelForm.java to accept default values for those three parameters.
Could you please take a look at the patch ModelForm_default_values.patch.
Once that's ok I will remove those three parameters from the catalog/category/products/features forms.
Thanks
Marco
> New Styles For Catalog application
> ----------------------------------
>
> Key: OFBIZ-1544
> URL: https://issues.apache.org/jira/browse/OFBIZ-1544
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ModelForm_default_values.patch, new_style_catalogs_products2.patch.zip, new_style_product.patch, new_style_product2.patch, style.png
>
>
> Apply the new CSS styles to all the form into the catalog application and we will have the same look and feel on the ftl screens and screen widgets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.