[GitHub] [pulsar] Shoothzj commented on a change in pull request #13424: Allow to config no-password truststore

[GitBox <gi...@apache.org>]

Shoothzj commented on a change in pull request #13424:
URL: https://github.com/apache/pulsar/pull/13424#discussion_r773500013



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/keystoretls/KeyStoreSSLContext.java
##########
@@ -105,7 +105,11 @@ public KeyStoreSSLContext(Mode mode,
                 ? DEFAULT_KEYSTORE_TYPE
                 : trustStoreTypeString;
         this.trustStorePath = trustStorePath;
-        this.trustStorePassword = trustStorePassword;
+        if (trustStorePassword == null) {
+            this.trustStorePassword = "";
+        } else {
+            this.trustStorePassword = trustStorePassword;
+        }

Review comment:
       @michaeljmarshall I can't find a way to change the default value which in the config file to `""`, this will cause the inconsistent between config file and code. Could you give me some advice? :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org