[GitHub] [jena] kinow commented on a change in pull request #720: JENA-1875: Context for Turtle related stream writers.

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #720: JENA-1875: Context for Turtle related stream writers.
URL: https://github.com/apache/jena/pull/720#discussion_r401237836
 
 

 ##########
 File path: jena-arq/src/main/java/org/apache/jena/riot/system/RiotLib.java
 ##########
 @@ -342,45 +342,51 @@ private static void writeBaseOldStyle(IndentedWriter out, String base) {
         }
     }
 
-    /** Write prefixes, using {@code PREFIX} */ 
+    /** Write prefixes */ 
     public static void writePrefixes(IndentedWriter out, PrefixMap prefixMap, boolean newStyle) {
-        if ( newStyle )
-            writePrefixesNewStyle(out, prefixMap);
-        else
-            writePrefixesOldStyle(out, prefixMap);
-    }
-    
-    /** Write prefixes, using {@code PREFIX} */ 
-    private static void writePrefixesNewStyle(IndentedWriter out, PrefixMap prefixMap) {
         if ( prefixMap != null && !prefixMap.isEmpty() ) {
             for ( Map.Entry<String, String> e : prefixMap.getMapping().entrySet() ) {
-                out.print("PREFIX ");
-                out.print(e.getKey());
-                out.print(": ");
-                out.pad(PREFIX_IRI);
-                out.print("<");
-                out.print(e.getValue());
-                out.print(">");
-                out.println();
+                if ( newStyle )
+                    writePrefixNewStyle(out, e.getKey(), e.getValue());
+                else
+                    writePrefixOldStyle(out, e.getKey(), e.getValue());
             }
         }
     }
+    
+    /** Write a prefix.
+     * Write using {@code @prefix} or {@code PREFIX}.
+     */ 
+    public static void writePrefix(IndentedWriter out, String prefix, String uri, boolean newStyle) {
+        if ( newStyle )
+            writePrefixNewStyle(out, prefix, uri);
+        else
+            writePrefixOldStyle(out, prefix, uri);
+    }
+
+    /** Write prefix, using {@code PREFIX} */ 
+    private static void writePrefixNewStyle(IndentedWriter out, String prefix, String uri) {
+        out.print("PREFIX ");
+        out.print(prefix);
+        out.print(": ");
+        out.pad(PREFIX_IRI);
+        out.print("<");
+        out.print(uri);
+        out.print(">");
+        out.println();
 
 Review comment:
   Just checking, the other one looks like Turtle with a `.` at the end. This new style doesn't need that right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org