You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/02/25 22:24:33 UTC
Review Request 70054: Added FrameworkInfo.offer_filters to
multi-scheduler scalability docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70054/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Meng Zhu.
Bugs: MESOS-9578
https://issues.apache.org/jira/browse/MESOS-9578
Repository: mesos
Description
-------
Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.
Diffs
-----
docs/app-framework-development-guide.md 8b0e5455f0e8a251581eaaf75143c5c4b5e556fc
Diff: https://reviews.apache.org/r/70054/diff/1/
Testing
-------
N/A
Thanks,
Benjamin Mahler
Re: Review Request 70054: Added FrameworkInfo.offer_filters to
multi-scheduler scalability docs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70054/#review213206
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70054]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 26, 2019, 6:24 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70054/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2019, 6:24 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Meng Zhu.
>
>
> Bugs: MESOS-9578
> https://issues.apache.org/jira/browse/MESOS-9578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 8b0e5455f0e8a251581eaaf75143c5c4b5e556fc
>
>
> Diff: https://reviews.apache.org/r/70054/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 70054: Added FrameworkInfo.offer_filters to
multi-scheduler scalability docs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70054/#review213202
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70054]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 25, 2019, 10:24 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70054/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2019, 10:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Meng Zhu.
>
>
> Bugs: MESOS-9578
> https://issues.apache.org/jira/browse/MESOS-9578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 8b0e5455f0e8a251581eaaf75143c5c4b5e556fc
>
>
> Diff: https://reviews.apache.org/r/70054/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 70054: Added FrameworkInfo.offer_filters to
multi-scheduler scalability docs.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70054/#review213208
-----------------------------------------------------------
Fix it, then Ship it!
docs/app-framework-development-guide.md
Lines 61-65 (patched)
<https://reviews.apache.org/r/70054/#comment299078>
Given the name "filters", probably worth explaining the difference between this and the current filters?
- Meng Zhu
On Feb. 25, 2019, 2:24 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70054/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2019, 2:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Meng Zhu.
>
>
> Bugs: MESOS-9578
> https://issues.apache.org/jira/browse/MESOS-9578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 8b0e5455f0e8a251581eaaf75143c5c4b5e556fc
>
>
> Diff: https://reviews.apache.org/r/70054/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 70054: Added FrameworkInfo.offer_filters to
multi-scheduler scalability docs.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70054/
-----------------------------------------------------------
(Updated Feb. 26, 2019, 8:45 p.m.)
Review request for mesos, Benjamin Bannier and Meng Zhu.
Changes
-------
Updated with more explanation per Meng's suggestion.
Bugs: MESOS-9578
https://issues.apache.org/jira/browse/MESOS-9578
Repository: mesos
Description
-------
Added FrameworkInfo.offer_filters to multi-scheduler scalability docs.
Diffs (updated)
-----
docs/app-framework-development-guide.md 8b0e5455f0e8a251581eaaf75143c5c4b5e556fc
Diff: https://reviews.apache.org/r/70054/diff/2/
Changes: https://reviews.apache.org/r/70054/diff/1-2/
Testing
-------
N/A
Thanks,
Benjamin Mahler