You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2026/09/03 16:32:50 UTC
(maven-wagon) 04/04: Honor usePreemptive for PUT requests in AbstractHttpClientWagon
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch wagon-3.x
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
commit 0e76d6c174a720b38df2cdc093b0e9d1a46116a1
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Thu Sep 3 18:27:36 2026 +0200
Honor usePreemptive for PUT requests in AbstractHttpClientWagon
Remove unguarded preemptive auth priming in AbstractHttpClientWagon.put()
so that PUT requests only authenticate preemptively when configured.
Update HttpWagonTest accordingly.
Fixes #909.
---
.../maven/wagon/shared/http/AbstractHttpClientWagon.java | 13 -------------
.../apache/maven/wagon/providers/http/HttpWagonTest.java | 2 +-
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
index a93d8217..7adb5862 100644
--- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
+++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
@@ -687,19 +687,6 @@ private void put(int wait, Resource resource, File source, HttpEntity httpEntity
fireTransferError(resource, e, TransferEvent.REQUEST_PUT);
}
- // preemptive for put
- // TODO: is it a good idea, though? 'Expect-continue' handshake would serve much better
-
- // FIXME Perform only when preemptive has been configured
- Repository repo = getRepository();
- HttpHost targetHost = new HttpHost(repo.getHost(), repo.getPort(), repo.getProtocol());
- AuthScope targetScope = getBasicAuthScope().getScope(targetHost);
-
- if (credentialsProvider.getCredentials(targetScope) != null) {
- BasicScheme targetAuth = new BasicScheme(StandardCharsets.UTF_8);
- authCache.put(targetHost, targetAuth);
- }
-
HttpPut putMethod = new HttpPut(url);
firePutStarted(resource, source);
diff --git a/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTest.java b/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTest.java
index e900d459..43df8746 100755
--- a/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTest.java
+++ b/wagon-providers/wagon-http/src/test/java/org/apache/maven/wagon/providers/http/HttpWagonTest.java
@@ -49,7 +49,7 @@ protected void setHttpConfiguration(StreamingWagon wagon, Properties headers, Pr
@Override
protected boolean supportPreemptiveAuthenticationPut() {
- return true;
+ return false;
}
@Override