You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/10 20:01:37 UTC
[GitHub] [arrow-rs] Dandandan opened a new pull request #281: Speed up bound checking in `take`
Dandandan opened a new pull request #281:
URL: https://github.com/apache/arrow-rs/pull/281
# Which issue does this PR close?
Closes #280
# Rationale for this change
\>2x speed up for common case (non-null indices)
```
take check bounds i32 512
time: [618.35 ns 619.16 ns 620.08 ns]
change: [-55.905% -55.474% -55.115%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild
Benchmarking take check bounds i32 1024: Collecting 100 samples in estimated 5.0026 s (4.7M iteratio take check bounds i32 1024
time: [1.0389 us 1.0409 us 1.0430 us]
change: [-57.474% -57.278% -57.093%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
```
# What changes are included in this PR?
Speed up kernel with bound checking option on.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me merged pull request #281: Speed up bound checking in `take`
Posted by GitBox <gi...@apache.org>.
nevi-me merged pull request #281:
URL: https://github.com/apache/arrow-rs/pull/281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan commented on pull request #281: Speed up bound checking in `take`
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #281:
URL: https://github.com/apache/arrow-rs/pull/281#issuecomment-837254012
FYI @jorgecarleitao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org