[GitHub] [iceberg] kbendick commented on a diff in pull request #5530: Build: Bump gradle-baseline-java from 4.0.0 to 4.42.0

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5530:
URL: https://github.com/apache/iceberg/pull/5530#discussion_r947056550


##########
aws/src/integration/java/org/apache/iceberg/aws/lakeformation/LakeFormationTestBase.java:
##########
@@ -351,7 +351,7 @@ private static void registerResource(String s3Location) {
       // when a resource is registered, LF will update SLR with necessary permissions which has a propagation delay
       waitForIamConsistency();
     } catch (AlreadyExistsException e) {
-      LOG.warn("Resource {} already registered. Error: {}", arn, e);
+      LOG.warn("Resource {} already registered. Error: {}", arn, e.getMessage(), e);

Review Comment:
   This is just an integration test, so not a big deal. But does it make sense to log both `e.getMessage()` along with `e`?
   
   I don't want to change the aws integration tests too much, but if we weren't inside the aws integration tests I would suggest `LOG.warn("Resource {} already registered", arn, e)` instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org