You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/11/19 13:17:29 UTC

Review Request 28229: AMS config properties initial value issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28229/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-8383
    https://issues.apache.org/jira/browse/AMBARI-8383


Repository: ambari


Description
-------

There are issues with initial values of some config properties of forthcoming AMS service.
hbase.tmp.dir has empty value (issue caught only when HBase is also chosen for installation).
hbase.zookeeper.quorum should not be set as list of ZooKeeper Server hosts.


Diffs
-----

  ambari-web/app/controllers/wizard/step7_controller.js 2b6f570 
  ambari-web/app/models/service_config.js 221e63c 
  ambari-web/test/models/service_config_test.js 6929566 

Diff: https://reviews.apache.org/r/28229/diff/


Testing
-------

 4859 tests complete (8 seconds)
  60 tests pending


Thanks,

Andrii Tkach


Re: Review Request 28229: AMS config properties initial value issues

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28229/#review62150
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Nov. 19, 2014, 12:17 p.m., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28229/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 12:17 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-8383
>     https://issues.apache.org/jira/browse/AMBARI-8383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are issues with initial values of some config properties of forthcoming AMS service.
> hbase.tmp.dir has empty value (issue caught only when HBase is also chosen for installation).
> hbase.zookeeper.quorum should not be set as list of ZooKeeper Server hosts.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step7_controller.js 2b6f570 
>   ambari-web/app/models/service_config.js 221e63c 
>   ambari-web/test/models/service_config_test.js 6929566 
> 
> Diff: https://reviews.apache.org/r/28229/diff/
> 
> 
> Testing
> -------
> 
>  4859 tests complete (8 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>