[GitHub] cloudstack pull request #1604: improvement: systemvm slow operations

[jburwell <gi...@git.apache.org>]

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1604#discussion_r77684136
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -584,9 +584,11 @@ def hasIP(self, ip):
             return ip in self.address.values()
     
         def arpPing(self):
    +        if not self.address['gateway'] or self.address['gateway'] == 'None':
    +            return
             cmd = "arping -c 1 -I %s -A -U -s %s %s" % (
                 self.dev, self.address['public_ip'], self.address['gateway'])
    -        CsHelper.execute(cmd)
    +        CsHelper.execute(cmd, wait=False)
    --- End diff --
    
    Flag arguments are an anti-pattern.  Please consider introducing and ``executeAndWait`` function instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---