[GitHub] [spark] cloud-fan commented on a change in pull request #27798: [SPARK-31045][SQL] Add config for AQE logging level

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27798: [SPARK-31045][SQL] Add config for AQE logging level
URL: https://github.com/apache/spark/pull/27798#discussion_r388231574
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -394,6 +394,18 @@ object SQLConf {
     .booleanConf
     .createWithDefault(false)
 
+  val ADAPTIVE_EXECUTION_LOG_LEVEL = buildConf("spark.sql.adaptive.logLevel")
+    .internal()
+    .doc("Configures the log level for adaptive execution logging. The value can be 'trace', " +
+      "'debug', 'info', 'warn', or 'error'. The default log level is 'debug'.")
+    .version("3.0.0")
+    .stringConf
+    .transform(_.toUpperCase(Locale.ROOT))
+    .checkValue(logLevel => Set("TRACE", "DEBUG", "INFO", "WARN", "ERROR").contains(logLevel),
 
 Review comment:
   nit: `checkValues(Set("TRACE", "DEBUG", "INFO", "WARN", "ERROR"))`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org