You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by as...@apache.org on 2026/10/09 12:47:30 UTC

(maka) branch main updated: fix(ui): render failed-turn and retry notices as card banners (#6021)

This is an automated email from the ASF dual-hosted git repository.

Astro-Han pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/maka.git


The following commit(s) were added to refs/heads/main by this push:
     new 53f4c0b654 fix(ui): render failed-turn and retry notices as card banners (#6021)
53f4c0b654 is described below

commit 53f4c0b654eebd0cfaec62d6a9b3a54104980d16
Author: 小七 <gg...@gmail.com>
AuthorDate: Fri Oct 9 20:47:25 2026 +0800

    fix(ui): render failed-turn and retry notices as card banners (#6021)
    
    A failed turn's banner and the provider retry notice both passed
    `container="section"` to Astryx `Banner`. That variant is the page-level,
    full-bleed, square-cornered surface, so the 800px message column showed a
    hard-edged block of status color that read as a page alert instead of part
    of the turn (#5799).
    
    Drop the prop so both fall back to the default `card` container β€” the
    standalone, rounded variant for content inside a column. Nothing else
    changes: the retry notice keeps its `role="status"` live region with the
    aria-hidden countdown (stable accessible name, see
    `ModelProviderRetryIndicator`), and every `.maka-turn-failed-banner` rule
    in styles.css was audited β€” all of them set block rhythm or style the
    `<pre>` diagnostic, none compensate the section shape, so none is dead.
    
    Fixes #5799
    
    Generated-by: GLM-5.3-Flash (ZCode)
---
 packages/ui/src/chat-turn.tsx             | 1 -
 packages/ui/src/provider-retry-notice.tsx | 1 -
 2 files changed, 2 deletions(-)

diff --git a/packages/ui/src/chat-turn.tsx b/packages/ui/src/chat-turn.tsx
index 2d29af49c6..20119a8c69 100644
--- a/packages/ui/src/chat-turn.tsx
+++ b/packages/ui/src/chat-turn.tsx
@@ -784,7 +784,6 @@ export const TurnView = memo(function TurnView(props: {
               {ownsTurnChrome && turn.status === 'failed' && props.failedReasonLabel && (
                 <Banner
                   status={props.failedSeverity ?? 'error'}
-                  container="section"
                   className="maka-turn-failed-banner"
                   title={props.failedReasonLabel}
                   description={
diff --git a/packages/ui/src/provider-retry-notice.tsx b/packages/ui/src/provider-retry-notice.tsx
index 0d384c9fab..56e0c64b09 100644
--- a/packages/ui/src/provider-retry-notice.tsx
+++ b/packages/ui/src/provider-retry-notice.tsx
@@ -29,7 +29,6 @@ export const ProviderRetryNotice = forwardRef<HTMLDivElement, {
     <Banner
       ref={ref}
       status="warning"
-      container="section"
       role="status"
       className="maka-turn-provider-retry"
       {...(props.accessibleLabel ? { 'aria-label': props.accessibleLabel } : {})}


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org