You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2015/06/17 12:18:17 UTC

[1/2] git commit: updated refs/heads/master to 85afa63

Repository: cloudstack
Updated Branches:
  refs/heads/master 441a13252 -> 85afa63f2


Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressManagerImpl.java Assert isn't used in prod runtime

Signed-off-by: Daan Hoogland <da...@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/b34ad4a2
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/b34ad4a2
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/b34ad4a2

Branch: refs/heads/master
Commit: b34ad4a22cd660bb3e99a9647d873c72b84235d3
Parents: 441a132
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 21:50:16 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Wed Jun 17 12:18:00 2015 +0200

----------------------------------------------------------------------
 server/src/com/cloud/network/IpAddressManagerImpl.java | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/b34ad4a2/server/src/com/cloud/network/IpAddressManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/network/IpAddressManagerImpl.java b/server/src/com/cloud/network/IpAddressManagerImpl.java
index 7ca06a2..f73a549 100644
--- a/server/src/com/cloud/network/IpAddressManagerImpl.java
+++ b/server/src/com/cloud/network/IpAddressManagerImpl.java
@@ -580,7 +580,6 @@ public class IpAddressManagerImpl extends ManagerBase implements IpAddressManage
 
         IPAddressVO ip = markIpAsUnavailable(addrId);
 
-        assert (ip != null) : "Unable to mark the ip address id=" + addrId + " as unavailable.";
         if (ip == null) {
             return true;
         }


[2/2] git commit: updated refs/heads/master to 85afa63

Posted by da...@apache.org.
Re-run travis

Signed-off-by: Daan Hoogland <da...@gmail.com>

This closes #456


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/85afa63f
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/85afa63f
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/85afa63f

Branch: refs/heads/master
Commit: 85afa63f24e2058e6c3bb7db1751444f1b2aa7c6
Parents: b34ad4a
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Mon Jun 15 17:30:14 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Wed Jun 17 12:18:01 2015 +0200

----------------------------------------------------------------------
 server/src/com/cloud/network/IpAddressManagerImpl.java | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/85afa63f/server/src/com/cloud/network/IpAddressManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/network/IpAddressManagerImpl.java b/server/src/com/cloud/network/IpAddressManagerImpl.java
index f73a549..552e56b 100644
--- a/server/src/com/cloud/network/IpAddressManagerImpl.java
+++ b/server/src/com/cloud/network/IpAddressManagerImpl.java
@@ -579,7 +579,6 @@ public class IpAddressManagerImpl extends ManagerBase implements IpAddressManage
         }
 
         IPAddressVO ip = markIpAsUnavailable(addrId);
-
         if (ip == null) {
             return true;
         }