You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Simon Pepping <sp...@leverkruid.nl> on 2005/10/27 21:22:12 UTC

Position and order of pendingaftermarks

Jeremias,

In the SpaceResolver constructor the pendingaftermarks are added to
the start of first:

first.addAll(0, breakPoss.getPendingAfterMarks());

I think they should be added to the end. Also I think the order of the
pendingaftermarks in BreakElement is wrong, or they should be added to
first in reverse order.

This is a test case:

<fo:block space-after="10pt" space-before="10pt"
  background-color="#555555">
  <fo:block space-after="7pt" space-before="7pt"
    background-color="#555555">
    <fo:block space-after="5pt" background-color="#656565">
      Some text.
    </fo:block>
    <fo:block space-before="4pt" background-color="#757575">
      Some text.
    </fo:block>
  </fo:block>
</fo:block>

Regards, Simon

-- 
Simon Pepping
home page: http://www.leverkruid.nl

Re: Position and order of pendingaftermarks

Posted by Simon Pepping <sp...@leverkruid.nl>.
On Thu, Oct 27, 2005 at 09:33:46PM +0200, Jeremias Maerki wrote:
> Would you mind handling this yourself? Adding the test case, adding
> checks and possibly fixing the bug? I'm away tomorrow and the whole of
> next week and I'm only just cleaning up my stuff before I go to bed. I
> don't know how much time I'll have during the weekend to look into this.

Will do. It is just that I make no promises as to when.

Simon

-- 
Simon Pepping
home page: http://www.leverkruid.nl

Re: Position and order of pendingaftermarks

Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Would you mind handling this yourself? Adding the test case, adding
checks and possibly fixing the bug? I'm away tomorrow and the whole of
next week and I'm only just cleaning up my stuff before I go to bed. I
don't know how much time I'll have during the weekend to look into this.

Thanks!

On 27.10.2005 21:22:12 Simon Pepping wrote:
> Jeremias,
> 
> In the SpaceResolver constructor the pendingaftermarks are added to
> the start of first:
> 
> first.addAll(0, breakPoss.getPendingAfterMarks());
> 
> I think they should be added to the end. Also I think the order of the
> pendingaftermarks in BreakElement is wrong, or they should be added to
> first in reverse order.
> 
> This is a test case:
> 
> <fo:block space-after="10pt" space-before="10pt"
>   background-color="#555555">
>   <fo:block space-after="7pt" space-before="7pt"
>     background-color="#555555">
>     <fo:block space-after="5pt" background-color="#656565">
>       Some text.
>     </fo:block>
>     <fo:block space-before="4pt" background-color="#757575">
>       Some text.
>     </fo:block>
>   </fo:block>
> </fo:block>


Jeremias Maerki