You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/22 03:02:09 UTC
[GitHub] [pulsar] Gleiphir2769 opened a new pull request, #17789: [doc] [client] [go] [do not merge] Add chunking to go-client doc
Gleiphir2769 opened a new pull request, #17789:
URL: https://github.com/apache/pulsar/pull/17789
Master Issue: pulsar-client-go [#865](https://github.com/apache/pulsar-client-go/pull/805)
### Motivation
Add chunking document for go-client. (Do not merge now. [#865](https://github.com/apache/pulsar-client-go/pull/805) is under review now.)
### Modifications
Add chunking document for go-client.
### Documentation
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
### Matching PR in forked repository
PR in forked repository: https://github.com/Gleiphir2769/pulsar-client-go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#discussion_r1005157282
##########
site2/docs/client-libraries-go.md:
##########
@@ -204,6 +204,34 @@ for i := 0; i < 10; i++ {
}
```
+#### How to use chunking in producer
+
+```go
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: serviceURL,
+})
+
+if err != nil {
+ log.Fatal(err)
+}
+defer client.Close()
+
+// The message chunking feature is OFF by default.
+// By default, producer chunks the large message based on max message size (maxMessageSize) configured at broker (eg: 5MB).
+// Client can also configure max chunked size using producer configuration ChunkMaxMessageSize.
Review Comment:
```suggestion
// Client can also configure the max chunked size using the producer configuration `ChunkMaxMessageSize`.
```
##########
site2/docs/client-libraries-go.md:
##########
@@ -204,6 +204,34 @@ for i := 0; i < 10; i++ {
}
```
+#### How to use chunking in producer
+
+```go
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: serviceURL,
+})
+
+if err != nil {
+ log.Fatal(err)
+}
+defer client.Close()
+
+// The message chunking feature is OFF by default.
+// By default, producer chunks the large message based on max message size (maxMessageSize) configured at broker (eg: 5MB).
Review Comment:
```suggestion
// By default, a producer chunks the large message based on the max message size (`maxMessageSize`) configured at the broker side (for example, 5MB).
```
##########
site2/docs/client-libraries-go.md:
##########
@@ -204,6 +204,34 @@ for i := 0; i < 10; i++ {
}
```
+#### How to use chunking in producer
+
+```go
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: serviceURL,
+})
+
+if err != nil {
+ log.Fatal(err)
+}
+defer client.Close()
+
+// The message chunking feature is OFF by default.
+// By default, producer chunks the large message based on max message size (maxMessageSize) configured at broker (eg: 5MB).
+// Client can also configure max chunked size using producer configuration ChunkMaxMessageSize.
+// Attention, to enable chunking, you need to disable batching (DisableBatching=true) concurrently.
Review Comment:
```suggestion
// Note: to enable chunking, you need to disable batching (`DisableBatching=true`) concurrently.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Gleiphir2769 commented on pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Gleiphir2769 commented on PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#issuecomment-1289872132
> Thanks for your contribution! Feel free to add your updates to https://docs.google.com/spreadsheets/d/1YHYTkIXR8-Ql103u-IMI18TXLlGStK8uJjDsOOA0T20/edit#gid=1784579914 once the PRs get merged.
@Anonymitaet Hi, the ralated pr has merged https://github.com/apache/pulsar-client-go/pull/805. But I have no permits to edit this doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17789: [doc] [client] [go] [do not merge] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#issuecomment-1255741110
@RobertIndie @nodece could you please review this PR after https://github.com/apache/pulsar-client-go/pull/805 is merged? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#discussion_r1004307616
##########
site2/docs/client-libraries-go.md:
##########
@@ -204,6 +204,34 @@ for i := 0; i < 10; i++ {
}
```
+#### How to use chunking in producer
+
+```go
+client, err := NewClient(pulsar.ClientOptions{
Review Comment:
```suggestion
client, err := pulsar.NewClient(pulsar.ClientOptions{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17789: [doc] [client] [go] [do not merge] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#issuecomment-1288319085
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17789: [doc] [client] [go] [do not merge] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#issuecomment-1255720288
Thanks for your contribution! Feel free to add your updates to https://docs.google.com/spreadsheets/d/1YHYTkIXR8-Ql103u-IMI18TXLlGStK8uJjDsOOA0T20/edit#gid=1784579914 once the PRs get merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece merged pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
nodece merged PR #17789:
URL: https://github.com/apache/pulsar/pull/17789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Gleiphir2769 commented on pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Gleiphir2769 commented on PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#issuecomment-1289912345
@RobertIndie @nodece Hi, could you review this PR and merge it soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Gleiphir2769 commented on a diff in pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Gleiphir2769 commented on code in PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#discussion_r1005134420
##########
site2/docs/client-libraries-go.md:
##########
@@ -204,6 +204,34 @@ for i := 0; i < 10; i++ {
}
```
+#### How to use chunking in producer
+
+```go
+client, err := NewClient(pulsar.ClientOptions{
Review Comment:
@nodece Thx, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Gleiphir2769 commented on pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Gleiphir2769 commented on PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#issuecomment-1289877605
> > > Thanks for your contribution! Feel free to add your updates to https://docs.google.com/spreadsheets/d/1YHYTkIXR8-Ql103u-IMI18TXLlGStK8uJjDsOOA0T20/edit#gid=1784579914 once the PRs get merged.
> >
> >
> > @Anonymitaet Hi, the ralated pr has merged [apache/pulsar-client-go#805](https://github.com/apache/pulsar-client-go/pull/805). But I have no permits to edit this doc.
>
> @Gleiphir2769 can you leave comments in https://docs.google.com/spreadsheets/d/1YHYTkIXR8-Ql103u-IMI18TXLlGStK8uJjDsOOA0T20/edit#gid=1784579914? Then I'll copy your changes to that file, thanks!
@Anonymitaet Done, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Gleiphir2769 commented on a diff in pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Gleiphir2769 commented on code in PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#discussion_r1005465097
##########
site2/docs/client-libraries-go.md:
##########
@@ -204,6 +204,34 @@ for i := 0; i < 10; i++ {
}
```
+#### How to use chunking in producer
+
+```go
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: serviceURL,
+})
+
+if err != nil {
+ log.Fatal(err)
+}
+defer client.Close()
+
+// The message chunking feature is OFF by default.
+// By default, producer chunks the large message based on max message size (maxMessageSize) configured at broker (eg: 5MB).
Review Comment:
Good suggestion, thx!
##########
site2/docs/client-libraries-go.md:
##########
@@ -204,6 +204,34 @@ for i := 0; i < 10; i++ {
}
```
+#### How to use chunking in producer
+
+```go
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: serviceURL,
+})
+
+if err != nil {
+ log.Fatal(err)
+}
+defer client.Close()
+
+// The message chunking feature is OFF by default.
+// By default, producer chunks the large message based on max message size (maxMessageSize) configured at broker (eg: 5MB).
+// Client can also configure max chunked size using producer configuration ChunkMaxMessageSize.
Review Comment:
Good suggestion, thx!
##########
site2/docs/client-libraries-go.md:
##########
@@ -204,6 +204,34 @@ for i := 0; i < 10; i++ {
}
```
+#### How to use chunking in producer
+
+```go
+client, err := pulsar.NewClient(pulsar.ClientOptions{
+ URL: serviceURL,
+})
+
+if err != nil {
+ log.Fatal(err)
+}
+defer client.Close()
+
+// The message chunking feature is OFF by default.
+// By default, producer chunks the large message based on max message size (maxMessageSize) configured at broker (eg: 5MB).
+// Client can also configure max chunked size using producer configuration ChunkMaxMessageSize.
+// Attention, to enable chunking, you need to disable batching (DisableBatching=true) concurrently.
Review Comment:
Good suggestion, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17789: [doc] [client] [go] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#issuecomment-1289873669
> > Thanks for your contribution! Feel free to add your updates to https://docs.google.com/spreadsheets/d/1YHYTkIXR8-Ql103u-IMI18TXLlGStK8uJjDsOOA0T20/edit#gid=1784579914 once the PRs get merged.
>
> @Anonymitaet Hi, the ralated pr has merged [apache/pulsar-client-go#805](https://github.com/apache/pulsar-client-go/pull/805). But I have no permits to edit this doc.
@Gleiphir2769 can you leave comments in https://docs.google.com/spreadsheets/d/1YHYTkIXR8-Ql103u-IMI18TXLlGStK8uJjDsOOA0T20/edit#gid=1784579914? Then I'll copy your changes to that file, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Gleiphir2769 commented on pull request #17789: [doc] [client] [go] [do not merge] Add chunking to go-client doc
Posted by GitBox <gi...@apache.org>.
Gleiphir2769 commented on PR #17789:
URL: https://github.com/apache/pulsar/pull/17789#issuecomment-1255726448
> Thanks for your contribution! Feel free to add your updates to https://docs.google.com/spreadsheets/d/1YHYTkIXR8-Ql103u-IMI18TXLlGStK8uJjDsOOA0T20/edit#gid=1784579914 once the PRs get merged.
OK, I will add it when the PR has merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org