You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/01/22 05:22:01 UTC
Re: Review Request: Slave Restart (Part 6): Added os::islink and substituted
stat() with lstat() in os.hpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8681/#review15558
-----------------------------------------------------------
third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/8681/#comment33585>
Okay, so if this is a link to a directory, it will now return false ... are those the semantics we want? WDPD?
third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/8681/#comment33586>
Ditto above.
third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/8681/#comment33587>
Yeah, definitely want this one to be lstat.
third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/8681/#comment33588>
This one makes me suspicious ... what do other libraries do?
- Benjamin Hindman
On Dec. 19, 2012, 6:03 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8681/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2012, 6:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Needed this for my next review.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/os.hpp 76e5e0624af36a0021755fb4acf7f76bfb81a823
>
> Diff: https://reviews.apache.org/r/8681/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Slave Restart (Part 6): Added os::islink and substituted
stat() with lstat() in os.hpp
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 22, 2013, 4:22 a.m., Benjamin Hindman wrote:
> > third_party/libprocess/include/stout/os.hpp, line 365
> > <https://reviews.apache.org/r/8681/diff/1/?file=241084#file241084line365>
> >
> > Okay, so if this is a link to a directory, it will now return false ... are those the semantics we want? WDPD?
actually, on second-thought, i think stat() is better here. otherwise, it would be hard to answer "is this a link to a directory/file".
> On Jan. 22, 2013, 4:22 a.m., Benjamin Hindman wrote:
> > third_party/libprocess/include/stout/os.hpp, line 410
> > <https://reviews.apache.org/r/8681/diff/1/?file=241084#file241084line410>
> >
> > This one makes me suspicious ... what do other libraries do?
i'm not sure what libraries to look at? fwiw, 'ls' shows the mod time of the link, not the target.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8681/#review15558
-----------------------------------------------------------
On Dec. 19, 2012, 6:03 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8681/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2012, 6:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Needed this for my next review.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/os.hpp 76e5e0624af36a0021755fb4acf7f76bfb81a823
>
> Diff: https://reviews.apache.org/r/8681/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>