You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/07 20:58:19 UTC
Review Request 65957: Updated Windows documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65957/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, Eric Mumau, and Joseph Wu.
Repository: mesos
Description
-------
This notes that Developer Mode is required for non-admin symlinks,
removes reference to the close JIRA epic, and adds information on how
to build with Ninja on Windows.
Diffs
-----
docs/windows.md cf2c7c230ec9fc062b4a4fe721d7669ef646253c
Diff: https://reviews.apache.org/r/65957/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65957: Updated Windows documentation.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65957/#review198835
-----------------------------------------------------------
Fix it, then Ship it!
docs/windows.md
Line 17 (original), 17 (patched)
<https://reviews.apache.org/r/65957/#comment279081>
I don't think "unpaid" can be used in that way. "free of charge" works.
docs/windows.md
Lines 99 (patched)
<https://reviews.apache.org/r/65957/#comment279082>
Ninja will pick the first compiler that's in your `$PATH`, so it picked GCC for me. You should mention that you can fix that by setting CC and CXX environmental variables like `$env:CC=$(Get-Command).Source` and `$env:CXX=$(Get-Command cl).Source`
- Akash Gupta
On March 7, 2018, 8:58 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65957/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 8:58 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, Eric Mumau, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This notes that Developer Mode is required for non-admin symlinks,
> removes reference to the close JIRA epic, and adds information on how
> to build with Ninja on Windows.
>
>
> Diffs
> -----
>
> docs/windows.md cf2c7c230ec9fc062b4a4fe721d7669ef646253c
>
>
> Diff: https://reviews.apache.org/r/65957/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65957: Updated Windows documentation.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65957/#review198838
-----------------------------------------------------------
docs/windows.md
Line 17 (original), 17 (patched)
<https://reviews.apache.org/r/65957/#comment279085>
That works. I just didn't want to conflate with "free software" because VS is definitely not. Thanks!
docs/windows.md
Lines 99 (patched)
<https://reviews.apache.org/r/65957/#comment279087>
Eh, if you have GCC installed on Windows, I figure you already know what you're doing. This was more of a "getting started" not how to fix any bug with it. Setting CXX and CC applies to more than just Ninja, too, that's generic CMake.
- Andrew Schwartzmeyer
On March 7, 2018, 12:58 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65957/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 12:58 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, Eric Mumau, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This notes that Developer Mode is required for non-admin symlinks,
> removes reference to the close JIRA epic, and adds information on how
> to build with Ninja on Windows.
>
>
> Diffs
> -----
>
> docs/windows.md cf2c7c230ec9fc062b4a4fe721d7669ef646253c
>
>
> Diff: https://reviews.apache.org/r/65957/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65957: Updated Windows documentation.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65957/#review198823
-----------------------------------------------------------
PASS: Mesos patch 65957 was successfully built and tested.
Reviews applied: `['65719', '65721', '65720', '65957']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65957
- Mesos Reviewbot Windows
On March 7, 2018, 8:58 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65957/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 8:58 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, Eric Mumau, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This notes that Developer Mode is required for non-admin symlinks,
> removes reference to the close JIRA epic, and adds information on how
> to build with Ninja on Windows.
>
>
> Diffs
> -----
>
> docs/windows.md cf2c7c230ec9fc062b4a4fe721d7669ef646253c
>
>
> Diff: https://reviews.apache.org/r/65957/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>