You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GabrielBrascher <gi...@git.apache.org> on 2016/03/19 19:59:56 UTC

[GitHub] cloudstack pull request: Remove unused code from XenServerStorageP...

GitHub user GabrielBrascher opened a pull request:

    https://github.com/apache/cloudstack/pull/1443

    Remove unused code from XenServerStorageProcessor and change methods access level

    Remove unused code from "com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor" class and modify some methods access level.
    
    Remove unused methods:
    - com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSRByNameLabel(Connection,
    String)
    - com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getNfsSR(Connection,
    StorageFilerTO)
    - com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.directDownloadHttpTemplate(CopyCommand,
    DecodedDataObject, DecodedDataObject)
    - com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.execute(AttachPrimaryDataStoreCmd)
    
    
    change access level:
    - from public to private:
    com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftUpload(Connection,
    SwiftTO, String, String, String, Boolean, int)
    - from public to protected:
    com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftBackupSnapshot(Connection,
    SwiftTO, String, String, String, Boolean, int)
    - from protected to private:
    com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSnapshotSize(Connection,
    String, String, Boolean, int)
    - from protected to private:
    com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.backupSnapshot(Connection,
    String, String, String, String, String, String, Boolean, int)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GabrielBrascher/cloudstack lrg-cs-hackday-028

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1443
    
----
commit eb437b225a83bdcd114458145c83642944814e42
Author: gabrascher <ga...@hotmail.com>
Date:   2016-03-19T18:49:47Z

    Remove unused code from
    "com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor"
    class and modify some methods access level.
    
    Remove unused methods:
    - com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSRByNameLabel(Connection,
    String)
    - com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getNfsSR(Connection,
    StorageFilerTO)
    - com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.directDownloadHttpTemplate(CopyCommand,
    DecodedDataObject, DecodedDataObject)
    - com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.execute(AttachPrimaryDataStoreCmd)
    
    
    access level:
    - from public to private:
    com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftUpload(Connection,
    SwiftTO, String, String, String, Boolean, int)
    - from public to protected:
    com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftBackupSnapshot(Connection,
    SwiftTO, String, String, String, Boolean, int)
    - from protected to private:
    com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSnapshotSize(Connection,
    String, String, Boolean, int)
    - from protected to private:
    com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.backupSnapshot(Connection,
    String, String, String, String, String, String, Boolean, int)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9314 - Remove unused code from...

Posted by rafaelweingartner <gi...@git.apache.org>.

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1443#issuecomment-204199455
  
    It is a nice clean up, thanks @GabrielBrascher 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1443: CLOUDSTACK-9314 - Remove unused code from XenServerS...

Posted by bvbharatk <gi...@git.apache.org>.

Github user bvbharatk commented on the issue:

    https://github.com/apache/cloudstack/pull/1443
  
    ### ACS CI BVT Run
     **Sumarry:**
     Build Number 178
     Hypervisor xenserver
     NetworkType Advanced
     Passed=72
     Failed=1
     Skipped=3
    
    _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
    
    
    **Failed tests:**
    * test_vpc_vpn.py
    
     * test_01_vpc_remote_access_vpn Failed
    
    
    **Skipped tests:**
    test_vm_nic_adapter_vmxnet3
    test_static_role_account_acls
    test_deploy_vgpu_enabled_vm
    
    **Passed test suits:**
    test_deploy_vm_with_userdata.py
    test_affinity_groups_projects.py
    test_portable_publicip.py
    test_over_provisioning.py
    test_global_settings.py
    test_scale_vm.py
    test_service_offerings.py
    test_routers_iptables_default_policy.py
    test_routers.py
    test_reset_vm_on_reboot.py
    test_snapshots.py
    test_deploy_vms_with_varied_deploymentplanners.py
    test_login.py
    test_list_ids_parameter.py
    test_public_ip_range.py
    test_multipleips_per_nic.py
    test_regions.py
    test_affinity_groups.py
    test_network_acl.py
    test_pvlan.py
    test_volumes.py
    test_nic.py
    test_deploy_vm_root_resize.py
    test_resource_detail.py
    test_secondary_storage.py
    test_vm_life_cycle.py
    test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---