You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Josh Rosen (JIRA)" <ji...@apache.org> on 2014/12/17 21:18:13 UTC
[jira] [Resolved] (SPARK-4714) BlockManager should check whether
blocks have already been removed Checking block is null or not after having
gotten info.lock in remove block method
[ https://issues.apache.org/jira/browse/SPARK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Rosen resolved SPARK-4714.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.2.1
I've merged this into {{branch-1.2}}, so this will be included in 1.2.1. Since that was the last remaining backport, I'm marking this as Fixed.
> BlockManager should check whether blocks have already been removed Checking block is null or not after having gotten info.lock in remove block method
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SPARK-4714
> URL: https://issues.apache.org/jira/browse/SPARK-4714
> Project: Spark
> Issue Type: Improvement
> Components: Block Manager
> Affects Versions: 1.1.0
> Reporter: SuYan
> Assignee: SuYan
> Priority: Minor
> Fix For: 1.0.3, 1.3.0, 1.1.2, 1.2.1
>
>
> in removeBlock()/ dropOldBlock()/ dropFromMemory()
> all have the same logic:
> 1. info = blockInfo.get(id)
> 2. if (info != null)
> 3. info.synchronized
> there may be a possibility that while one thread got info.lock while the previous thread already removed from blockinfo in info.lock.
> but one thing in current code, That not check info is null or not, while get info.lock to remove block, will not cause any errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org