You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2015/07/15 15:17:34 UTC
[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-js/pull/121
CB-9370 Fixes failing tests on Node 0.12 due to stale dependency
This PR fixes tests on AppVeyor, broken by updated NodeJS on CI machines as described in [CB-9370](https://issues.apache.org/jira/browse/CB-9370). It also adds build matrix that includes node 0.10 and 0.12 for both Travis and AppVeyor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-js CB-9370
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 715e2bbefc25ca9c20f476c2f5f2a906b1356c85
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-07-15T13:00:17Z
CB-9291 Loosens requirement for NodeJS version
commit 55003223d23dbf1dd20fa5c21a70c9d0fdf96db3
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-07-15T13:05:21Z
CB-9370 Fixes failing tests on Node 0.12 due to stale dependency
This also adds Node@0.12 to test matrix for both Travis and AppVeyor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/121#discussion_r34685625
--- Diff: package.json ---
@@ -9,7 +9,7 @@
"url": "http://git-wip-us.apache.org/repos/asf/cordova-js.git"
},
"engines": {
- "node": "~0.10.x"
+ "node": ">=0.10.x"
--- End diff --
This seems fine and should be a non-issue for most people - but I think we should just remove it unless we really have a dependency on node >= 0.10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/121#discussion_r34707474
--- Diff: package.json ---
@@ -9,7 +9,7 @@
"url": "http://git-wip-us.apache.org/repos/asf/cordova-js.git"
},
"engines": {
- "node": "~0.10.x"
+ "node": ">=0.10.x"
--- End diff --
yeah, not needed IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-js/pull/121#issuecomment-121743440
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/121#discussion_r34686348
--- Diff: package.json ---
@@ -9,7 +9,7 @@
"url": "http://git-wip-us.apache.org/repos/asf/cordova-js.git"
},
"engines": {
- "node": "~0.10.x"
+ "node": ">=0.10.x"
--- End diff --
Sounds good. @stevengill, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-js/pull/121#issuecomment-121638909
LGTM overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-js/pull/121#issuecomment-135681546
Yes, using `jsdom` was a mistake. I switched to `jsdom-no-contextify` which doesn't have any native dependencies: https://github.com/apache/cordova-js/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org