You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/24 02:26:18 UTC
[GitHub] [skywalking] wankai123 opened a new pull request #8465: E2E: Add normal field to Service
wankai123 opened a new pull request #8465:
URL: https://github.com/apache/skywalking/pull/8465
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
related to: https://github.com/apache/skywalking/pull/8463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on pull request #8465: E2E: Add normal field to Service
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #8465:
URL: https://github.com/apache/skywalking/pull/8465#issuecomment-1019658993
@wankai123 @wu-sheng Shall we expose `isNormal` in `ServiceTraffic` with a `@Getter` annotation, since it is used to build the entity for storage layer.
I guess it is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #8465: E2E: Add normal field to Service
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #8465:
URL: https://github.com/apache/skywalking/pull/8465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 edited a comment on pull request #8465: E2E: Add normal field to Service
Posted by GitBox <gi...@apache.org>.
lujiajing1126 edited a comment on pull request #8465:
URL: https://github.com/apache/skywalking/pull/8465#issuecomment-1019658993
@wankai123 @wu-sheng Shall we expose `isNormal` in `ServiceTraffic` with a `@Getter` annotation, since it is used to build the entity for the storage layer.
I guess it is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on pull request #8465: E2E: Add normal field to Service
Posted by GitBox <gi...@apache.org>.
wankai123 commented on pull request #8465:
URL: https://github.com/apache/skywalking/pull/8465#issuecomment-1019663541
> @wankai123 @wu-sheng Shall we expose `isNormal` in `ServiceTraffic` with a `@Getter` annotation, since it is used to build the entity for storage layer.
>
> I guess it is missing.
@lujiajing1126 We don't persistent this field, it's just used to build `service_id` internal. We recommend to get this info from
`IDManager.ServiceIDDefinition.isreal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org