You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by laskfla <gi...@git.apache.org> on 2018/10/26 11:25:02 UTC
[GitHub] spark pull request #22850: [MINOR][DOC] Fix comment error of HiveUtils
GitHub user laskfla opened a pull request:
https://github.com/apache/spark/pull/22850
[MINOR][DOC] Fix comment error of HiveUtils
## What changes were proposed in this pull request?
Change the version number in comment of `HiveUtils.newClientForExecution` from `13` to `1.2.1` .
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laskfla/spark HiveUtils-Comment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22850.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22850
----
commit 92a60c48f3f24d227eed284005f8d74711cb81f2
Author: laskfla <ww...@...>
Date: 2018-10-26T11:15:24Z
fix comment error of newClientForExecution
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22850
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22850
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22850
**[Test build #98087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98087/testReport)** for PR 22850 at commit [`92a60c4`](https://github.com/apache/spark/commit/92a60c48f3f24d227eed284005f8d74711cb81f2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22850
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22850
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22850
**[Test build #98087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98087/testReport)** for PR 22850 at commit [`92a60c4`](https://github.com/apache/spark/commit/92a60c48f3f24d227eed284005f8d74711cb81f2).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by laskfla <gi...@git.apache.org>.
Github user laskfla commented on the issue:
https://github.com/apache/spark/pull/22850
@HyukjinKwon ，I checked the file and looks like the others looks good.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22850
cc @dongjoon-hyun
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22850
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22850
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98087/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22850
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22850: [MINOR][DOC] Fix comment error of HiveUtils
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22850
Yea, I was aware of it. I think there are some more old comments in this file if I remember this correctly. Can you double check and fix them while we are here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org