You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/11 20:35:10 UTC

[GitHub] [nifi] bbende opened a new pull request #4525: NIFI-7802 Remove commons-configuration2 dependency from nifi-security…

bbende opened a new pull request #4525:
URL: https://github.com/apache/nifi/pull/4525


   …-utils which ends up `nifi-standard-services-api` and on the classpath of any standard services
   
   The dependency on commons-configuration2 was added to `nifi-security-utils` as part of this ticket:
   https://issues.apache.org/jira/browse/NIFI-6301
   
   The only class the uses the dependency is `SafeXMLConfiguration`, so I created a new module `nifi-security-xml-config` and moved this class and the dependency there, so that it doesn't get pulled into everywhere that security utils is being used.
   
   I considered making the module be just `nifi-security-xml-utils` and moving the other XML classes as well, but then there may also be another case where you want to use those classes without using commons-configuration2.
   
   In the future we should further separate `nifi-security-utils`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] thenatog commented on pull request #4525: NIFI-7802 Remove commons-configuration2 dependency from nifi-security…

Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691516380


   Tested with a PropertiesFileLookupService and an XMLFileLookupService, looks good. Contrib check + tests all passed.
   
   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] thenatog commented on pull request #4525: NIFI-7802 Remove commons-configuration2 dependency from nifi-security…

Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691315601






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] thenatog commented on pull request #4525: NIFI-7802 Remove commons-configuration2 dependency from nifi-security…

Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691315601






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] thenatog commented on pull request #4525: NIFI-7802 Remove commons-configuration2 dependency from nifi-security…

Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691315601


   Reviewing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] thenatog closed pull request #4525: NIFI-7802 Remove commons-configuration2 dependency from nifi-security…

Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #4525:
URL: https://github.com/apache/nifi/pull/4525


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] thenatog commented on pull request #4525: NIFI-7802 Remove commons-configuration2 dependency from nifi-security…

Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691315601






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org