You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/05/25 16:59:39 UTC
Review Request 47834: refactor decodeAddressToBytes into two methods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47834/
-----------------------------------------------------------
Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda.
Bugs: GEODE-1451
https://issues.apache.org/jira/browse/GEODE-1451
Repository: geode
Description
-------
The boolean parameters have been removed and two
methods now exist:
1. decodeAddressToRawBytes(long)
2. decodeUncompressedAddressToBytes(long)
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 8b57c43b0d4d31b8c5691a11f82a0acaad1340aa
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java aee1b15e46df8b44d5d22a63263ae24fb6fab6bb
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b9b3dfcc831453951d0954b482a8ec6f72262eb5
Diff: https://reviews.apache.org/r/47834/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 47834: refactor decodeAddressToBytes into two
methods
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47834/#review135007
-----------------------------------------------------------
Ship it!
Ship It!
- Ken Howe
On May 25, 2016, 10:38 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47834/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 10:38 p.m.)
>
>
> Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1451
> https://issues.apache.org/jira/browse/GEODE-1451
>
>
> Repository: geode
>
>
> Description
> -------
>
> The boolean parameters have been removed and two
> methods now exist:
> 1. decodeAddressToRawBytes(long)
> 2. decodeUncompressedAddressToBytes(long)
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 8b57c43b0d4d31b8c5691a11f82a0acaad1340aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java aee1b15e46df8b44d5d22a63263ae24fb6fab6bb
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b9b3dfcc831453951d0954b482a8ec6f72262eb5
>
> Diff: https://reviews.apache.org/r/47834/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 47834: refactor decodeAddressToBytes into two
methods
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47834/
-----------------------------------------------------------
(Updated May 25, 2016, 3:38 p.m.)
Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda.
Changes
-------
now uses assert keyword
updated test method names
Bugs: GEODE-1451
https://issues.apache.org/jira/browse/GEODE-1451
Repository: geode
Description
-------
The boolean parameters have been removed and two
methods now exist:
1. decodeAddressToRawBytes(long)
2. decodeUncompressedAddressToBytes(long)
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 8b57c43b0d4d31b8c5691a11f82a0acaad1340aa
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java aee1b15e46df8b44d5d22a63263ae24fb6fab6bb
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b9b3dfcc831453951d0954b482a8ec6f72262eb5
Diff: https://reviews.apache.org/r/47834/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 47834: refactor decodeAddressToBytes into two
methods
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47834/#review134798
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java (line 212)
<https://reviews.apache.org/r/47834/#comment199710>
Change test name consistent with the name of the method under test.
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java (line 223)
<https://reviews.apache.org/r/47834/#comment199709>
Change test name consistent with the name of the method under test.
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java (line 234)
<https://reviews.apache.org/r/47834/#comment199708>
Change test name consistent with the name of the method under test. Expected exception changes to AssertionError based on my previous comment.
- Ken Howe
On May 25, 2016, 4:59 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47834/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 4:59 p.m.)
>
>
> Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1451
> https://issues.apache.org/jira/browse/GEODE-1451
>
>
> Repository: geode
>
>
> Description
> -------
>
> The boolean parameters have been removed and two
> methods now exist:
> 1. decodeAddressToRawBytes(long)
> 2. decodeUncompressedAddressToBytes(long)
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 8b57c43b0d4d31b8c5691a11f82a0acaad1340aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java aee1b15e46df8b44d5d22a63263ae24fb6fab6bb
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b9b3dfcc831453951d0954b482a8ec6f72262eb5
>
> Diff: https://reviews.apache.org/r/47834/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 47834: refactor decodeAddressToBytes into two
methods
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47834/#review134793
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java (lines 289 - 292)
<https://reviews.apache.org/r/47834/#comment199705>
This should probably be a Java assert rather throwing the UnsupportedOperationException, similar to the fix for GEODE-1296
- Ken Howe
On May 25, 2016, 4:59 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47834/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 4:59 p.m.)
>
>
> Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1451
> https://issues.apache.org/jira/browse/GEODE-1451
>
>
> Repository: geode
>
>
> Description
> -------
>
> The boolean parameters have been removed and two
> methods now exist:
> 1. decodeAddressToRawBytes(long)
> 2. decodeUncompressedAddressToBytes(long)
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 8b57c43b0d4d31b8c5691a11f82a0acaad1340aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java aee1b15e46df8b44d5d22a63263ae24fb6fab6bb
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b9b3dfcc831453951d0954b482a8ec6f72262eb5
>
> Diff: https://reviews.apache.org/r/47834/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 47834: refactor decodeAddressToBytes into two
methods
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47834/#review134785
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java (line 23)
<https://reviews.apache.org/r/47834/#comment199695>
remove unused import
- Darrel Schneider
On May 25, 2016, 9:59 a.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47834/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 9:59 a.m.)
>
>
> Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1451
> https://issues.apache.org/jira/browse/GEODE-1451
>
>
> Repository: geode
>
>
> Description
> -------
>
> The boolean parameters have been removed and two
> methods now exist:
> 1. decodeAddressToRawBytes(long)
> 2. decodeUncompressedAddressToBytes(long)
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java 8b57c43b0d4d31b8c5691a11f82a0acaad1340aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java aee1b15e46df8b44d5d22a63263ae24fb6fab6bb
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java b9b3dfcc831453951d0954b482a8ec6f72262eb5
>
> Diff: https://reviews.apache.org/r/47834/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>