You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/06/29 19:31:12 UTC
Review Request 36004: Config directories for HDP-2.3 should use
conf-select
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Bugs: AMBARI-12201
https://issues.apache.org/jira/browse/AMBARI-12201
Repository: ambari
Description
-------
* Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
* When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
Diffs
-----
ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
Diff: https://reviews.apache.org/r/36004/diff/
Testing
-------
Testing Done
Several manual scenarios:
* Fresh install of HDP-2.3 (no upgrade)
* Upgrade HDP-2.3 to HDP-2.3+
* Upgrade HDP-2.2 to HDP-2.3
* (Pending) Downgrade HDP-2.3 to HDP-2.3-
* (Pending) Downgrade HDP-2.3 to HDP-2.2
Automated:
Total run:768
Total errors:0
Total failures:0
OK
Thanks,
Nate Cole
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/
-----------------------------------------------------------
(Updated June 29, 2015, 4:23 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Bugs: AMBARI-12201
https://issues.apache.org/jira/browse/AMBARI-12201
Repository: ambari
Description
-------
* Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
* When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
Diffs
-----
ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
Diff: https://reviews.apache.org/r/36004/diff/
Testing (updated)
-------
Testing Done
Several manual scenarios:
* Fresh install of HDP-2.3 (no upgrade)
* Upgrade HDP-2.3 to HDP-2.3+
* Upgrade HDP-2.2 to HDP-2.3
* Downgrade HDP-2.3 to HDP-2.3-
* Downgrade HDP-2.3 to HDP-2.2
Automated:
Total run:768
Total errors:0
Total failures:0
OK
Thanks,
Nate Cole
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/#review89782
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On June 29, 2015, 3:23 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36004/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 3:23 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-12201
> https://issues.apache.org/jira/browse/AMBARI-12201
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
> * When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
> ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
>
> Diff: https://reviews.apache.org/r/36004/diff/
>
>
> Testing
> -------
>
> Testing Done
> Several manual scenarios:
> * Fresh install of HDP-2.3 (no upgrade)
> * Upgrade HDP-2.3 to HDP-2.3+
> * Upgrade HDP-2.2 to HDP-2.3
> * (Pending) Downgrade HDP-2.3 to HDP-2.3-
> * Downgrade HDP-2.3 to HDP-2.2
>
> Automated:
> Total run:768
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/#review89786
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On June 29, 2015, 7:23 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36004/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 7:23 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-12201
> https://issues.apache.org/jira/browse/AMBARI-12201
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
> * When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
> ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
>
> Diff: https://reviews.apache.org/r/36004/diff/
>
>
> Testing
> -------
>
> Testing Done
> Several manual scenarios:
> * Fresh install of HDP-2.3 (no upgrade)
> * Upgrade HDP-2.3 to HDP-2.3+
> * Upgrade HDP-2.2 to HDP-2.3
> * (Pending) Downgrade HDP-2.3 to HDP-2.3-
> * Downgrade HDP-2.3 to HDP-2.2
>
> Automated:
> Total run:768
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/
-----------------------------------------------------------
(Updated June 29, 2015, 3:23 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
Changes
-------
Updated test results
Bugs: AMBARI-12201
https://issues.apache.org/jira/browse/AMBARI-12201
Repository: ambari
Description
-------
* Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
* When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
Diffs
-----
ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
Diff: https://reviews.apache.org/r/36004/diff/
Testing (updated)
-------
Testing Done
Several manual scenarios:
* Fresh install of HDP-2.3 (no upgrade)
* Upgrade HDP-2.3 to HDP-2.3+
* Upgrade HDP-2.2 to HDP-2.3
* (Pending) Downgrade HDP-2.3 to HDP-2.3-
* Downgrade HDP-2.3 to HDP-2.2
Automated:
Total run:768
Total errors:0
Total failures:0
OK
Thanks,
Nate Cole
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Nate Cole <nc...@hortonworks.com>.
> On June 29, 2015, 3:04 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py, line 71
> > <https://reviews.apache.org/r/36004/diff/1/?file=994440#file994440line71>
> >
> > Documentation so that someone doesn't need to read through the whole function to see what the end result is.
Will do.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/#review89772
-----------------------------------------------------------
On June 29, 2015, 1:31 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36004/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 1:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-12201
> https://issues.apache.org/jira/browse/AMBARI-12201
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
> * When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
> ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
>
> Diff: https://reviews.apache.org/r/36004/diff/
>
>
> Testing
> -------
>
> Testing Done
> Several manual scenarios:
> * Fresh install of HDP-2.3 (no upgrade)
> * Upgrade HDP-2.3 to HDP-2.3+
> * Upgrade HDP-2.2 to HDP-2.3
> * (Pending) Downgrade HDP-2.3 to HDP-2.3-
> * (Pending) Downgrade HDP-2.3 to HDP-2.2
>
> Automated:
> Total run:768
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/#review89772
-----------------------------------------------------------
ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py (line 71)
<https://reviews.apache.org/r/36004/#comment142567>
Documentation so that someone doesn't need to read through the whole function to see what the end result is.
- Jonathan Hurley
On June 29, 2015, 1:31 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36004/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 1:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-12201
> https://issues.apache.org/jira/browse/AMBARI-12201
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
> * When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
> ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
>
> Diff: https://reviews.apache.org/r/36004/diff/
>
>
> Testing
> -------
>
> Testing Done
> Several manual scenarios:
> * Fresh install of HDP-2.3 (no upgrade)
> * Upgrade HDP-2.3 to HDP-2.3+
> * Upgrade HDP-2.2 to HDP-2.3
> * (Pending) Downgrade HDP-2.3 to HDP-2.3-
> * (Pending) Downgrade HDP-2.3 to HDP-2.2
>
> Automated:
> Total run:768
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Nate Cole <nc...@hortonworks.com>.
> On June 29, 2015, 2:48 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py, line 46
> > <https://reviews.apache.org/r/36004/diff/1/?file=994440#file994440line46>
> >
> > This is the version either upgrading/downgrading to.
> >
> > In the case of a downgrade to 2.2.*, the link_config function will not be called.
> > May need to use config['hostLevelParams']['stack_version'] instead, which is the starting stack, e.g., HDP-2.2
>
> Nate Cole wrote:
> 2.2 uses the /etc/hadoop/conf link, not the conf-select linked one. In the case of downgrade to 2.2, we want to preserve that relationship only in 2.3 and higher do we use conf-select (it's not in 2.2). link_config should only get called when the target is 2.3 and higher.
Also, will double check the stack_version field - I don't recall it being there
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/#review89764
-----------------------------------------------------------
On June 29, 2015, 1:31 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36004/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 1:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-12201
> https://issues.apache.org/jira/browse/AMBARI-12201
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
> * When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
> ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
>
> Diff: https://reviews.apache.org/r/36004/diff/
>
>
> Testing
> -------
>
> Testing Done
> Several manual scenarios:
> * Fresh install of HDP-2.3 (no upgrade)
> * Upgrade HDP-2.3 to HDP-2.3+
> * Upgrade HDP-2.2 to HDP-2.3
> * (Pending) Downgrade HDP-2.3 to HDP-2.3-
> * (Pending) Downgrade HDP-2.3 to HDP-2.2
>
> Automated:
> Total run:768
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Nate Cole <nc...@hortonworks.com>.
> On June 29, 2015, 2:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, line 41
> > <https://reviews.apache.org/r/36004/diff/1/?file=994436#file994436line41>
> >
> > Are pig-client, hadoop-hdfs-client, hadoop-mapreduce-client, hadoop-yarn-client needed?
No, because those are dictated by hdp-select. The conf-select utility doesn't work against those.
> On June 29, 2015, 2:48 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py, line 46
> > <https://reviews.apache.org/r/36004/diff/1/?file=994440#file994440line46>
> >
> > This is the version either upgrading/downgrading to.
> >
> > In the case of a downgrade to 2.2.*, the link_config function will not be called.
> > May need to use config['hostLevelParams']['stack_version'] instead, which is the starting stack, e.g., HDP-2.2
2.2 uses the /etc/hadoop/conf link, not the conf-select linked one. In the case of downgrade to 2.2, we want to preserve that relationship only in 2.3 and higher do we use conf-select (it's not in 2.2). link_config should only get called when the target is 2.3 and higher.
> On June 29, 2015, 2:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, line 214
> > <https://reviews.apache.org/r/36004/diff/1/?file=994436#file994436line214>
> >
> > Safer to call upper() during comparison and before calling split, make sure that stack_id is not None.
Will fix.
> On June 29, 2015, 2:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, line 122
> > <https://reviews.apache.org/r/36004/diff/1/?file=994436#file994436line122>
> >
> > Would a dry_run return the conf name that would have been created?
No, it returns the conf directory name without actually creating the directory.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/#review89764
-----------------------------------------------------------
On June 29, 2015, 1:31 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36004/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 1:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-12201
> https://issues.apache.org/jira/browse/AMBARI-12201
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
> * When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
> ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
>
> Diff: https://reviews.apache.org/r/36004/diff/
>
>
> Testing
> -------
>
> Testing Done
> Several manual scenarios:
> * Fresh install of HDP-2.3 (no upgrade)
> * Upgrade HDP-2.3 to HDP-2.3+
> * Upgrade HDP-2.2 to HDP-2.3
> * (Pending) Downgrade HDP-2.3 to HDP-2.3-
> * (Pending) Downgrade HDP-2.3 to HDP-2.2
>
> Automated:
> Total run:768
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 36004: Config directories for HDP-2.3 should use
conf-select
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36004/#review89764
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 41)
<https://reviews.apache.org/r/36004/#comment142564>
Are pig-client, hadoop-hdfs-client, hadoop-mapreduce-client, hadoop-yarn-client needed?
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 122)
<https://reviews.apache.org/r/36004/#comment142557>
Would a dry_run return the conf name that would have been created?
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 214)
<https://reviews.apache.org/r/36004/#comment142559>
Safer to call upper() during comparison and before calling split, make sure that stack_id is not None.
ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py (line 46)
<https://reviews.apache.org/r/36004/#comment142562>
This is the version either upgrading/downgrading to.
In the case of a downgrade to 2.2.*, the link_config function will not be called.
May need to use config['hostLevelParams']['stack_version'] instead, which is the starting stack, e.g., HDP-2.2
- Alejandro Fernandez
On June 29, 2015, 5:31 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36004/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 5:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-12201
> https://issues.apache.org/jira/browse/AMBARI-12201
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fresh install of HDP-2.3 should use versioned config and symlink /etc/[component]/conf to /usr/hdp/current/[component-client-dir]/conf to /etc/[component]/[version]/0
> * When upgrading to HDP-2.3 (from either -2.2 or -2.3), invoke conf-select on known directories on install.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/shell.py 75d4e56
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 37b455d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py d2855b1
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py 1bd82ae
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 8d1c07f
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 2f2a518
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py 71ac3df
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 170f72e
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py d9e8c70
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py ded432b
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py fa3f717
> ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py d26813a
>
> Diff: https://reviews.apache.org/r/36004/diff/
>
>
> Testing
> -------
>
> Testing Done
> Several manual scenarios:
> * Fresh install of HDP-2.3 (no upgrade)
> * Upgrade HDP-2.3 to HDP-2.3+
> * Upgrade HDP-2.2 to HDP-2.3
> * (Pending) Downgrade HDP-2.3 to HDP-2.3-
> * (Pending) Downgrade HDP-2.3 to HDP-2.2
>
> Automated:
> Total run:768
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Nate Cole
>
>