[GitHub] [spark] PedroCorreiaLuis commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where…

[GitBox <gi...@apache.org>]

PedroCorreiaLuis commented on a change in pull request #26319: [SPARK-29594][SQL] Create a Dataset from a Sequence of Case class where…
URL: https://github.com/apache/spark/pull/26319#discussion_r410257658
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
 ##########
 @@ -543,6 +543,12 @@ object ScalaReflection extends ScalaReflection {
             throw new UnsupportedOperationException(s"`$fieldName` is a reserved keyword and " +
               "cannot be used as field name\n" + walkedTypePath)
           }
+          // It is ok to use head here because a variable name needs to be non empty
+          if (fieldName.head.isDigit) {
 
 Review comment:
   There is already one case for when the name is a Java keyword, this is the case when the name starts with a number, also possible in Scala but not in Java. I think it is better to "customize" exceptions explaining why the input cannot be like that, than having the exception with 0 information and the user without knowing what to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org