You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Behlendorf <br...@organic.com> on 1997/01/24 09:26:58 UTC

[PATCH] Re: ap_vsnprintf decl

On Fri, 24 Jan 1997, Marc Slemko wrote:
> >   *** Error code 1
> > 
> > Wha?
> 
> Try including stdarg.h in conf.h?  Actually, just move the existing
> include of stdarg.h from the bottom of conf.h to the top.  

I moved it to right before the ap_snprintf stuff.  Appears to work fine....
approve?


Index: conf.h
===================================================================
RCS file: /export/home/cvs/apache/src/conf.h,v
retrieving revision 1.71
diff -C3 -r1.71 conf.h
*** conf.h      1997/01/20 23:55:10     1.71
--- conf.h      1997/01/24 08:22:26
***************
*** 480,485 ****
--- 480,486 ----
   */

  #include <sys/types.h>
+ #include <stdarg.h>
  /*
   * We use snprintf() to avoid overflows, but we include
   * our own version (ap_snprintf). Allow for people to use their
***************
*** 490,495 ****
--- 491,497 ----
  #define ap_vsnprintf    vsnprintf
  #else
  int ap_snprintf(char *buf, size_t len, const char *format,...);
+ int ap_vsnprintf(char *buf, size_t len, const char *format, va_list ap);
  #endif

  #if !defined(NEXT) && !defined(CONVEXOS)
***************
*** 661,667 ****
  void syslog (int, char *, ...);
  char *mktemp (char *);

- #include <stdarg.h>
  long vfprintf (FILE *, char *, va_list);

  #endif
--- 663,668 ----



Re: [PATCH] Re: ap_vsnprintf decl

Posted by Marc Slemko <ma...@znep.com>.
On Fri, 24 Jan 1997, Brian Behlendorf wrote:

> On Fri, 24 Jan 1997, Marc Slemko wrote:
> > >   *** Error code 1
> > > 
> > > Wha?
> > 
> > Try including stdarg.h in conf.h?  Actually, just move the existing
> > include of stdarg.h from the bottom of conf.h to the top.  
> 
> I moved it to right before the ap_snprintf stuff.  Appears to work fine....
> approve?

Looks good to me.

> 
> 
> Index: conf.h
> ===================================================================
> RCS file: /export/home/cvs/apache/src/conf.h,v
> retrieving revision 1.71
> diff -C3 -r1.71 conf.h
> *** conf.h      1997/01/20 23:55:10     1.71
> --- conf.h      1997/01/24 08:22:26
> ***************
> *** 480,485 ****
> --- 480,486 ----
>    */
> 
>   #include <sys/types.h>
> + #include <stdarg.h>
>   /*
>    * We use snprintf() to avoid overflows, but we include
>    * our own version (ap_snprintf). Allow for people to use their
> ***************
> *** 490,495 ****
> --- 491,497 ----
>   #define ap_vsnprintf    vsnprintf
>   #else
>   int ap_snprintf(char *buf, size_t len, const char *format,...);
> + int ap_vsnprintf(char *buf, size_t len, const char *format, va_list ap);
>   #endif
> 
>   #if !defined(NEXT) && !defined(CONVEXOS)
> ***************
> *** 661,667 ****
>   void syslog (int, char *, ...);
>   char *mktemp (char *);
> 
> - #include <stdarg.h>
>   long vfprintf (FILE *, char *, va_list);
> 
>   #endif
> --- 663,668 ----
> 
>