You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by Thomas Guettler <gu...@interface-business.de> on 2000/10/30 17:26:08 UTC

patch to XMLParser

Here is a patch to XMLParser which fixes a type in the
features-string. (Why don't you use a singleton like
Features.load_dtd_grammar?). 

Index: XMLParser.java
===================================================================
RCS file: /home/cvspublic/xml-xerces/java/src/org/apache/xerces/framework/XMLParser.java,v
retrieving revision 1.22
diff -r1.22 XMLParser.java
1314c1314
<             // http://apache.org/xml/features/validation/load-dtd-grammar
---
>             // http://apache.org/xml/features/nonvalidation/load-dtd-grammar
1316c1316
<             if (feature.equals("load-dtd-grammar")) {
---
>             if (feature.equals("nonvalidation/load-dtd-grammar")) {


-- 
Thomas Guettler
Office: <gu...@interface-business.de> www.interface-business.de
Private:<gu...@gmx.de>  http://yi.org/guettli


Re: Please apply patch! Re: patch to XMLParser

Posted by Thomas Guettler <gu...@interface-business.de>.
Sorry, previous patch had a typo, too (who had the idea of using
hardcoded strings for the properties?). I hope think this one
is correct. 

--guettli@lux:~/xml-xerces/java/src/org/apache/xerces/framework$ cvs diff XMLParser.java
Index: XMLParser.java
===================================================================
RCS file: /home/cvspublic/xml-xerces/java/src/org/apache/xerces/framework/XMLParser.java,v
retrieving revision 1.22
diff -r1.22 XMLParser.java
1314c1314
<             // http://apache.org/xml/features/validation/load-dtd-grammar
---
>             // http://apache.org/xml/features/nonvalidating/load-dtd-grammar
1316c1316
<             if (feature.equals("load-dtd-grammar")) {
---
>             if (feature.equals("nonvalidating/load-dtd-grammar")) {


-- 
Thomas Guettler
Office: <gu...@interface-business.de> www.interface-business.de
Private:<gu...@gmx.de>  http://yi.org/guettli


Please apply patch! Re: patch to XMLParser

Posted by Thomas Guettler <gu...@interface-business.de>.
On Mon, Oct 30, 2000 at 11:24:16AM -0800, Andy Clark wrote:
> Thomas Guettler wrote:
> > Here is a patch to XMLParser which fixes a type in the
> > features-string. (Why don't you use a singleton like
> > Features.load_dtd_grammar?).
> 
> Good point. We are doing this in Xerces2.

Cool, but could some fix the typo of the current Xerces with my patch?

Index: XMLParser.java
===================================================================
RCS file: /home/cvspublic/xml-xerces/java/src/org/apache/xerces/framework/XMLParser.java,v
retrieving revision 1.22
diff -r1.22 XMLParser.java
1314c1314
<             // http://apache.org/xml/features/validation/load-dtd-grammar
---
>             // http://apache.org/xml/features/nonvalidation/load-dtd-grammar
1316c1316
<             if (feature.equals("load-dtd-grammar")) {
---
>             if (feature.equals("nonvalidation/load-dtd-grammar")) {


-- 
Thomas Guettler
Office: <gu...@interface-business.de> www.interface-business.de
Private:<gu...@gmx.de>  http://yi.org/guettli


Re: patch to XMLParser

Posted by Andy Clark <an...@apache.org>.
Thomas Guettler wrote:
> Here is a patch to XMLParser which fixes a type in the
> features-string. (Why don't you use a singleton like
> Features.load_dtd_grammar?).

Good point. We are doing this in Xerces2.

-- 
Andy Clark * IBM, JTC - Silicon Valley * andyc@apache.org