You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "daroga0002 (via GitHub)" <gi...@apache.org> on 2023/09/26 09:29:05 UTC
[GitHub] [apisix-ingress-controller] daroga0002 opened a new pull request, #1983: fix ginko versions
daroga0002 opened a new pull request, #1983:
URL: https://github.com/apache/apisix-ingress-controller/pull/1983
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
<!-- Select all the options from below that matches the type your PR best -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [ ] Documentation
- [ ] Refactor
- [ ] Chore
- [x] CI/CD or Tests
### What this PR does / why we need it:
This is solving issue with hardcoded version of Ginkgo module. There is strict dependency between tests in go using ginkgo package and local Ginkgo binary used for those tests. Currently after each update in dependencies CI start failing with log:
```sh
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
Ginkgo CLI Version:
2.12.0
Mismatched package versions found:
2.12.1 used by e2e
Ginkgo will continue to attempt to run but you may see errors (including flag
parsing errors) and should either update your go.mod or your version of the
Ginkgo CLI to match.
To install the matching version of the CLI run
go install github.com/onsi/ginkgo/v2/ginkgo
from a path that contains a go.mod file. Alternatively you can use
go run github.com/onsi/ginkgo/v2/ginkgo
from a path that contains a go.mod file to invoke the matching version of the
Ginkgo CLI.
If you are attempting to test multiple packages that each have a different
version of the Ginkgo library with a single Ginkgo CLI that is currently
unsupported.
```
This PR should fetch a correct version from e2e tests go.mod file and then install it in correct version.
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1983: fix: ginko versions in e2e tests
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1983:
URL: https://github.com/apache/apisix-ingress-controller/pull/1983#issuecomment-1735380684
## [Codecov](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1983](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/1983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6619c62) into [master](https://app.codecov.io/gh/apache/apisix-ingress-controller/commit/bca0d1da5e0d721ff7c94555821db55dd2659504?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bca0d1d) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 6619c62 differs from pull request most recent head d19d016. Consider uploading reports for the commit d19d016 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1983 +/- ##
=======================================
Coverage 36.87% 36.87%
=======================================
Files 93 93
Lines 7851 7851
=======================================
Hits 2895 2895
Misses 4568 4568
Partials 388 388
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Gallardot merged pull request #1983: fix: ginko versions in e2e tests
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot merged PR #1983:
URL: https://github.com/apache/apisix-ingress-controller/pull/1983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] daroga0002 commented on pull request #1983: fix: ginko versions in e2e tests
Posted by "daroga0002 (via GitHub)" <gi...@apache.org>.
daroga0002 commented on PR #1983:
URL: https://github.com/apache/apisix-ingress-controller/pull/1983#issuecomment-1735172157
It should be working correctly (locally tested and it is ok), but we will see when workflows will run what are results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org