[GitHub] [tvm] Lunderberg opened a new pull request, #15494: [Unity] Commutative pattern match based on relax.Expr op

["Lunderberg (via GitHub)" <gi...@apache.org>]

Lunderberg opened a new pull request, #15494:
URL: https://github.com/apache/tvm/pull/15494

   Prior to this commit, the commutative pattern matching was enabled based on the operation in the pattern.  As a result, commutative matches would only be checked if the match checked for a single operator, but not if the operator was itself a pattern that resolved to a commutative operator.
   
   ```python
   pattern_add = ExprPattern(Op.get("relax.add"))
   pattern_mul = ExprPattern(Op.get("relax.multiply"))
   
   uses_commutative_matching = pattern_add(lhs, rhs)
   no_commutative_matching = OrPattern(pattern_add, pattern_mul)(lhs, rhs)
   ```
   
   This commit updates the pattern matcher to check against the matched operator, rather than the pattern, to determine whether to check for commutative matches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15494: [Unity] Commutative pattern match based on relax.Expr op

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #15494:
URL: https://github.com/apache/tvm/pull/15494#issuecomment-1666901740

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] kparzysz-quic merged pull request #15494: [Unity] Commutative pattern match based on relax.Expr op

["kparzysz-quic (via GitHub)" <gi...@apache.org>]

kparzysz-quic merged PR #15494:
URL: https://github.com/apache/tvm/pull/15494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org