You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jantes <gi...@git.apache.org> on 2016/11/02 19:32:24 UTC
[GitHub] spark pull request #15739: [SPARK-16808][Core] prepend base URI for links on...
GitHub user jantes opened a pull request:
https://github.com/apache/spark/pull/15739
[SPARK-16808][Core] prepend base URI for links on main history server
## What changes were proposed in this pull request?
Make the 2.0.x Spark UI links work on systems with proxy servers by prepending the spark.ui.proxyBase or APPLICATION_WEB_PROXY_BASE to links on the first page. This is a regression from 1.6.x (although that was fixed at the caller).
Fixing it in the getAttemptURI places the entire URI generation in one place like done for other URI's in history making future regressions less likely.
## How was this patch tested?
Tested manually and dev/run-tests
@andrewor14
the contribution is original work and I license the work to the project under the project's open source license
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jantes/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15739
----
commit 164a08208ba795c91cd5a33f2213f8eea1b2d24e
Author: Jeff Antes <ja...@us.ibm.com>
Date: 2016-11-02T19:14:23Z
[SPARK-16808][Core] prepend base URI for links on main history server
page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the issue:
https://github.com/apache/spark/pull/15739
Also there's another patch trying to solve the same issue: #15742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15739
**[Test build #68079 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68079/consoleFull)** for PR 15739 at commit [`164a082`](https://github.com/apache/spark/commit/164a08208ba795c91cd5a33f2213f8eea1b2d24e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15739
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15739: [SPARK-16808][Core] prepend base URI for links on...
Posted by jantes <gi...@git.apache.org>.
Github user jantes closed the pull request at:
https://github.com/apache/spark/pull/15739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the issue:
https://github.com/apache/spark/pull/15739
ok to test @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...
Posted by jantes <gi...@git.apache.org>.
Github user jantes commented on the issue:
https://github.com/apache/spark/pull/15739
The other patch includes a testcase. Let's go with that one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15739
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15739
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68079/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15739: [SPARK-16808][Core] prepend base URI for links on main h...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15739
**[Test build #68079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68079/consoleFull)** for PR 15739 at commit [`164a082`](https://github.com/apache/spark/commit/164a08208ba795c91cd5a33f2213f8eea1b2d24e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org