[GitHub] [arrow] dragosmg commented on a change in pull request #11758: ARROW-13886 [R] Expand documentation for decimal()

[GitBox <gi...@apache.org>]

dragosmg commented on a change in pull request #11758:
URL: https://github.com/apache/arrow/pull/11758#discussion_r754534475



##########
File path: r/R/type.R
##########
@@ -187,8 +187,11 @@ NestedType <- R6Class("NestedType", inherit = DataType)
 #' @param timezone For `timestamp()`, an optional time zone string.
 #' @param byte_width byte width for `FixedSizeBinary` type.
 #' @param list_size list size for `FixedSizeList` type.
-#' @param precision For `decimal()`, precision
-#' @param scale For `decimal()`, scale
+#' @param precision For `decimal()`, precision. The number of significant digits

Review comment:
       Done

##########
File path: r/R/type.R
##########
@@ -187,8 +187,11 @@ NestedType <- R6Class("NestedType", inherit = DataType)
 #' @param timezone For `timestamp()`, an optional time zone string.
 #' @param byte_width byte width for `FixedSizeBinary` type.
 #' @param list_size list size for `FixedSizeList` type.
-#' @param precision For `decimal()`, precision
-#' @param scale For `decimal()`, scale
+#' @param precision For `decimal()`, precision. The number of significant digits
+#'    the arrow `decimal` type can represent. Currently `decimal()` is mapped
+#'    to `DecimalType128`, having a maximum precision of 38 significant digits.
+#' @param scale For `decimal()`, scale. The number of digits after the decimal

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org