You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@commons.apache.org by Glenn Goldenberg <gg...@Initiatesystems.com> on 2005/07/07 21:52:33 UTC
[betwixt] AddDefaultsRule bug in 0.7RC2
I think there may be a bug in the org.apache.commons.betwixt.digester.AddDefaultsRule class. I was testing the "add-adders" and "add-properties" flags on the <addDefaults> element in the .betwixt file. The flags didn't seem to work correctly, so I debugged into AddDefaultsRule and saw on line 69:
addProperties = Boolean.valueOf(addAddersAttributeValue).booleanValue();
I changed this to:
addAdders = Boolean.valueOf(addAddersAttributeValue).booleanValue();
and things worked as expected.
thanks,
glenn
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org
Re: [betwixt] AddDefaultsRule bug in 0.7RC2
Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
hi glenn
add-adder is indeed buggy. the unit tests seemed half written for this
feature :-/
i'm a little unsure how to proceed. either, the fix put into head or the
current release vote could be cancelled and this fix rolled into a fresh
release candidate.
opinions?
- robert
On Thu, 2005-07-07 at 14:52 -0500, Glenn Goldenberg wrote:
> I think there may be a bug in the org.apache.commons.betwixt.digester.AddDefaultsRule class. I was testing the "add-adders" and "add-properties" flags on the <addDefaults> element in the .betwixt file. The flags didn't seem to work correctly, so I debugged into AddDefaultsRule and saw on line 69:
>
> addProperties = Boolean.valueOf(addAddersAttributeValue).booleanValue();
>
> I changed this to:
>
> addAdders = Boolean.valueOf(addAddersAttributeValue).booleanValue();
>
> and things worked as expected.
>
> thanks,
> glenn
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-user-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org